From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73022 invoked by alias); 12 Aug 2015 13:38:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72978 invoked by uid 89); 12 Aug 2015 13:38:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 12 Aug 2015 13:38:29 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 6B2D219CBE7; Wed, 12 Aug 2015 13:38:27 +0000 (UTC) Received: from blade.nx (ovpn-116-40.ams2.redhat.com [10.36.116.40]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7CDcQeQ004797; Wed, 12 Aug 2015 09:38:27 -0400 Received: by blade.nx (Postfix, from userid 1000) id 1B2522643BE; Wed, 12 Aug 2015 14:38:26 +0100 (BST) Date: Wed, 12 Aug 2015 13:38:00 -0000 From: Gary Benson To: Pedro Alves Cc: Joel Brobecker , Doug Evans , Jan Kratochvil , gdb-patches , Sandra Loosemore , =?iso-8859-1?Q?Andr=E9_P=F6nitz?= , Paul Koning Subject: Re: [PATCH 0/2] Better handling of slow remote transfers Message-ID: <20150812133825.GA25961@blade.nx> References: <20150811195943.GC22245@adacore.com> <20150812094831.GD11096@blade.nx> <55CB1B8D.6010501@redhat.com> <20150812103831.GA12792@blade.nx> <55CB2DF8.2050506@redhat.com> <20150812123254.GA14726@blade.nx> <55CB4150.6090807@redhat.com> <20150812130248.GA15429@blade.nx> <55CB4B74.3070204@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55CB4B74.3070204@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00283.txt.bz2 Pedro Alves wrote: > On 08/12/2015 02:02 PM, Gary Benson wrote: > >>>> > > > I was only OK with trying to make transfers interruptible in the > >>>> > > > branch assuming it was something non-invasive, like a missing > >>>> > > > QUIT here and there. > >>> > > > >>> > > No, gdbserver sends the data in PBUFSIZ chunks, but GDB reads the > >>> > > data a character at a time. > >> > > >> > Can you expand on this? What code is it that reads the data a > >> > character at a time? What data is gdb getting at when it does that? > > I was looking in getpkt_or_notif_sane_1, but I think maybe I misread > > it. I'll get back to you on this... > > That's the very low level of RSP packets, which as you noted will > have a reasonable cap. It sounds to me there's a loop somewhere in > a higher layer that is missing a QUIT. E.g., we have quits > in dwarf2read.c which allow interrupting reading big binaries, > even if locally. So what is the higher level operation that > gdb is doing when you try to interrupt, but can't? remote_hostio_pread. I'm trying to make remote_hostio_pread interruptible. BFD is doing large remote_hostio_pread which are resulting in large vFile:pread: packet responses. Cheers, Gary -- http://gbenson.net/