From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44203 invoked by alias); 12 Aug 2015 13:29:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44194 invoked by uid 89); 12 Aug 2015 13:29:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 12 Aug 2015 13:29:54 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id BA13DFC0FE; Wed, 12 Aug 2015 13:29:52 +0000 (UTC) Received: from blade.nx (ovpn-116-40.ams2.redhat.com [10.36.116.40]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7CDTpEv009868; Wed, 12 Aug 2015 09:29:52 -0400 Received: by blade.nx (Postfix, from userid 1000) id 4B7D82643BE; Wed, 12 Aug 2015 14:29:51 +0100 (BST) Date: Wed, 12 Aug 2015 13:29:00 -0000 From: Gary Benson To: Pedro Alves Cc: Joel Brobecker , Doug Evans , Jan Kratochvil , gdb-patches , Sandra Loosemore , =?iso-8859-1?Q?Andr=E9_P=F6nitz?= , Paul Koning Subject: Re: [PATCH 0/2] Better handling of slow remote transfers Message-ID: <20150812132951.GA25587@blade.nx> References: <001a11c301b0388ac5051d0c5ab8@google.com> <20150811185519.GA28644@host1.jankratochvil.net> <20150811195943.GC22245@adacore.com> <20150812094831.GD11096@blade.nx> <55CB1B8D.6010501@redhat.com> <20150812103831.GA12792@blade.nx> <55CB2DF8.2050506@redhat.com> <20150812123254.GA14726@blade.nx> <55CB4150.6090807@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55CB4150.6090807@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00281.txt.bz2 Pedro Alves wrote: > On 08/12/2015 01:32 PM, Gary Benson wrote: > > Pedro Alves wrote: > > > I was only OK with trying to make transfers interruptible in the > > > branch assuming it was something non-invasive, like a missing > > > QUIT here and there. > > > > No, gdbserver sends the data in PBUFSIZ chunks, but GDB reads the > > data a character at a time. > > Can you expand on this? What code is it that reads the data a > character at a time? What data is gdb getting at when it does that? getpkt_or_notif_sane_1 in gdb/remote.c. If I'm reading it right GDB is reading every single byte coming over RSP individually. It doesn't work to put a QUIT in there as there's still stuff coming over the wire. If gdbserver sends data, GDB has to read it. You're way more familiar with RSP than I am. Do you know any way to make vFile:pread: interruptible? Cheers, Gary -- http://gbenson.net/