From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90378 invoked by alias); 11 Aug 2015 19:58:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90369 invoked by uid 89); 11 Aug 2015 19:58:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 11 Aug 2015 19:58:18 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9779D28F8B; Tue, 11 Aug 2015 15:58:16 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3dya7Gv-l4+8; Tue, 11 Aug 2015 15:58:16 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6B12528F69; Tue, 11 Aug 2015 15:58:16 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id EB44B46992; Tue, 11 Aug 2015 12:58:14 -0700 (PDT) Date: Tue, 11 Aug 2015 19:58:00 -0000 From: Joel Brobecker To: Doug Evans Cc: Pedro Alves , Simon Marchi , gdb-patches Subject: Re: [PATCH] Remove symlinks created in argv0-symlink.exp and general cleanup Message-ID: <20150811195814.GB22245@adacore.com> References: <1438287227-11303-1-git-send-email-simon.marchi@ericsson.com> <55BF7962.3060106@redhat.com> <55BF85BC.8040102@ericsson.com> <55BF9811.50202@redhat.com> <20150804172110.GI4777@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-08/txt/msg00249.txt.bz2 > I don't have a strong opinion on making in-tree testing unsupported, > but I do have a strong opinion on another thing that can make the > in-tree testing issue moot. > > Let's remove all of testsuite/*/Makefile.in, they're always > out of date anyway (i.e., no one updates gdb.foo/Makefile.in to > remove binaries added by new tests), > and except for "make clean" aren't really used for anything. > The "make clean" in testsuite/Makefile.in can just "rm -rf foo bar ..." > [where "foo bar ..." are *not* the gdb.* testsuite dirs, but rather > the outputs,etc. directories of check-parallel] > IOW, testing would create the needed directories on the fly, > even in serial mode, > and to simplify "make clean" they'd always be put in a fixed > subdir of testsuite (just like check-parallel does now). I think some of these issues are worth improving independently of whether the build was in-tree or not. > As for whether to always have one directory per test > (in serial and parallel modes), that *could* be treated as a separate > issue, but if it reduces complexity by doing the same thing > for serial and parallel then great. > [And while in-tree testing could still be unsupported, > I think(!) the current issue with it would be fixed.] If in-tree build happens to work without effort from us, then OK to continue having it. But I don't think treating as bugs issues that are specific to in-tree building & testing would be the best investment of our resources. I tried to remember why people thought in-tree building is more convenient for them, and couldn't remember of any reason other than convenience. But is it really more convenient? Are there other reasons I forgot about? -- Joel