From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80515 invoked by alias); 11 Aug 2015 10:52:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80499 invoked by uid 89); 11 Aug 2015 10:52:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 11 Aug 2015 10:52:25 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 2B09C55; Tue, 11 Aug 2015 10:52:24 +0000 (UTC) Received: from blade.nx (ovpn-116-40.ams2.redhat.com [10.36.116.40]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t7BAqMGT002979; Tue, 11 Aug 2015 06:52:23 -0400 Received: by blade.nx (Postfix, from userid 1000) id B9EB326243C; Tue, 11 Aug 2015 11:52:21 +0100 (BST) Date: Tue, 11 Aug 2015 10:52:00 -0000 From: Gary Benson To: Sandra Loosemore Cc: gdb-patches@sourceware.org, Doug Evans , Pedro Alves , Jan Kratochvil , =?iso-8859-1?Q?Andr=E9_P=F6nitz?= , Paul_Koning@Dell.com Subject: Re: [PATCH 2/2] Make remote file transfers interruptible Message-ID: <20150811105221.GA22087@blade.nx> References: <1438788496-32246-1-git-send-email-gbenson@redhat.com> <1438788496-32246-3-git-send-email-gbenson@redhat.com> <55C3A10F.3010106@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55C3A10F.3010106@codesourcery.com> X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00234.txt.bz2 Hi Sandra, Sandra Loosemore wrote: > On 08/05/2015 09:28 AM, Gary Benson wrote: > > This commit makes it possible to interrupt slow remote file transfers. > > > > gdb/ChangeLog: > > > > * gdb_bfd.c (gdb_bfd_iovec_fileio_pread): Add QUIT call. > > I think that this is the same patch that you sent earlier: > > https://sourceware.org/ml/gdb/2015-07/msg00043.html > > It still does not work for me. :-( Ok, given the packet-size limit of RSP I was assuming GDB would read the files in chunks the size of the server's packet buffer size (16k for gdbserver) but it seems that that chunking happens at a lower level, so the interrupt is only noticed between files rather than between chunks. I tested this patch using "remote get", but it seems that that operates differently. So I'm retracting this patch. Making remote transfers properly interruptible looks like a fairly involved task that's only slightly on my radar. I've filed a bug (https://sourceware.org/bugzilla/show_bug.cgi?id=18804) to keep the issue from being forgotten. I'll work on if I have some free time, or someone else can do it. The other patch in the series (the warning messages) can go in if people find it useful. Thanks, Gary -- http://gbenson.net/