From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96524 invoked by alias); 4 Aug 2015 08:28:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 96511 invoked by uid 89); 4 Aug 2015 08:28:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 04 Aug 2015 08:28:54 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id A2328B66B1 for ; Tue, 4 Aug 2015 08:28:53 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-20.ams2.redhat.com [10.36.116.20]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t748SoaI009925 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 4 Aug 2015 04:28:52 -0400 Date: Tue, 04 Aug 2015 08:28:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: [patch] signal_command: Leftover cleanup chain regression [Re: [PATCH 4/4] PR gdb/17471: Repeating a background command makes it foreground] Message-ID: <20150804082849.GA24816@host1.jankratochvil.net> References: <1412877629-12052-1-git-send-email-palves@redhat.com> <1412877629-12052-5-git-send-email-palves@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="lrZ03NoBR/3+SXJZ" Content-Disposition: inline In-Reply-To: <1412877629-12052-5-git-send-email-palves@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00060.txt.bz2 --lrZ03NoBR/3+SXJZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 44 Hi, mostly harmless but not correct. Jan --lrZ03NoBR/3+SXJZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename=1 Content-length: 604 gdb/ChangeLog 2015-08-04 Jan Kratochvil * infcmd.c (signal_command): Call do_cleanups for args_chain. diff --git a/gdb/infcmd.c b/gdb/infcmd.c index 4948d27..e4b2045 100644 --- a/gdb/infcmd.c +++ b/gdb/infcmd.c @@ -1264,6 +1264,8 @@ signal_command (char *signum_exp, int from_tty) oursig = gdb_signal_from_command (num); } + do_cleanups (args_chain); + /* Look for threads other than the current that this command ends up resuming too (due to schedlock off), and warn if they'll get a signal delivered. "signal 0" is used to suppress a previous --lrZ03NoBR/3+SXJZ--