From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-124574-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 115643 invoked by alias); 23 Jul 2015 17:22:02 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 115616 invoked by uid 89); 23 Jul 2015 17:22:01 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Jul 2015 17:21:54 +0000
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])	by mx1.redhat.com (Postfix) with ESMTPS id 3220CBB98C	for <gdb-patches@sourceware.org>; Thu, 23 Jul 2015 17:21:53 +0000 (UTC)
Received: from pinnacle.lan (ovpn-113-75.phx2.redhat.com [10.3.113.75])	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6NHLqxG010692	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA256 bits=256 verify=NO)	for <gdb-patches@sourceware.org>; Thu, 23 Jul 2015 13:21:53 -0400
Date: Thu, 23 Jul 2015 17:22:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add proper handling for non-local references in nested functions
Message-ID: <20150723102151.1b63fa2e@pinnacle.lan>
In-Reply-To: <55B112D4.5010304@adacore.com>
References: <54F47563.4050103@adacore.com>	<54FF0D05.70907@redhat.com>	<550C1170.9070208@adacore.com>	<55685B60.3000004@redhat.com>	<55775EB0.4080701@adacore.com>	<55AF5F7E.5000600@adacore.com>	<20150722173957.7ed51f18@pinnacle.lan>	<55B0C583.6050601@adacore.com>	<20150723064408.4dd8a9b2@pinnacle.lan>	<55B112D4.5010304@adacore.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2015-07/txt/msg00644.txt.bz2

On Thu, 23 Jul 2015 18:14:12 +0200
Pierre-Marie de Rodat <derodat@adacore.com> wrote:

> On 07/23/2015 03:44 PM, Kevin Buettner wrote:
>
> > I'll test your new patch today.  I've encountered a GDB bug related to
> > examining variables with within a nested function.  I'm hoping that
> > your patch will fix it...
> 
> I am as well: keep me updated! ;-)

I ran into another issue, both yesterday and today, when attempting to
apply your patch.  Apparently, it adds some test cases,
gdb.base/nested-subp1.c, gdb.base/nested-subp1.exp, etc. which already
exist.  As can be seen in the log below, I told patch to not assume -R
as well as to not apply the patch.  I'm using sources, current as of
yesterday, upon which I first applied your other patch,
0001-Replace-the-block_found-global-with-explicit-data-fl.patch.

Here's the log showing the issue I ran into:

[kev@pinnacle gdb]$ patch -p2 </tmp/0001-DWARF-handle-non-local-references-in-nested-function.patch 
patching file ada-lang.c
patching file block.c
patching file block.h
patching file buildsym.c
patching file buildsym.h
patching file c-exp.y
patching file coffread.c
patching file compile/compile-c-symbols.c
patching file compile/compile-loc2c.c
patching file d-exp.y
patching file dbxread.c
patching file dwarf2loc.c
patching file dwarf2loc.h
patching file dwarf2read.c
patching file f-exp.y
patching file findvar.c
patching file gdbtypes.c
patching file go-exp.y
patching file infcmd.c
patching file infrun.c
patching file jv-exp.y
patching file language.h
patching file m2-exp.y
patching file objfiles.c
patching file objfiles.h
patching file p-exp.y
patching file printcmd.c
patching file python/py-finishbreakpoint.c
patching file python/py-frame.c
patching file python/py-framefilter.c
patching file python/py-symbol.c
patching file stack.c
patching file symtab.h
The next patch would create the file testsuite/gdb.base/nested-subp1.c,
which already exists!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored
The next patch would create the file testsuite/gdb.base/nested-subp1.exp,
which already exists!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored
The next patch would create the file testsuite/gdb.base/nested-subp2.c,
which already exists!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored
The next patch would create the file testsuite/gdb.base/nested-subp2.exp,
which already exists!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored
The next patch would create the file testsuite/gdb.base/nested-subp3.c,
which already exists!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored
The next patch would create the file testsuite/gdb.base/nested-subp3.exp,
which already exists!  Assume -R? [n] n
Apply anyway? [n] n
Skipping patch.
1 out of 1 hunk ignored
patching file valops.c
patching file value.h
patching file xcoffread.c