From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2302 invoked by alias); 23 Jul 2015 13:44:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2221 invoked by uid 89); 23 Jul 2015 13:44:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Jul 2015 13:44:10 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id D277F342EB5 for ; Thu, 23 Jul 2015 13:44:09 +0000 (UTC) Received: from pinnacle.lan (ovpn-113-75.phx2.redhat.com [10.3.113.75]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6NDi8Rl003714 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA256 bits=256 verify=NO) for ; Thu, 23 Jul 2015 09:44:09 -0400 Date: Thu, 23 Jul 2015 13:44:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [PATCH] Add proper handling for non-local references in nested functions Message-ID: <20150723064408.4dd8a9b2@pinnacle.lan> In-Reply-To: <55B0C583.6050601@adacore.com> References: <54F47563.4050103@adacore.com> <54FF0D05.70907@redhat.com> <550C1170.9070208@adacore.com> <55685B60.3000004@redhat.com> <55775EB0.4080701@adacore.com> <55AF5F7E.5000600@adacore.com> <20150722173957.7ed51f18@pinnacle.lan> <55B0C583.6050601@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00633.txt.bz2 On Thu, 23 Jul 2015 12:44:19 +0200 Pierre-Marie de Rodat wrote: > Kevin, > > On 07/23/2015 02:39 AM, Kevin Buettner wrote: > > I had to make the following change in order to obtain a clean build > > using your patches: > > > > diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c > > index e20aead..d6e3d55 100644 > > --- a/gdb/dwarf2read.c > > +++ b/gdb/dwarf2read.c > > @@ -11457,7 +11457,7 @@ read_func_scope (struct die_info *die, struct dwarf2_cu *cu) > > > > newobj = pop_context (); > > /* Make a block for the local symbols within. */ > > - block = finish_block (newobj->name, &newobj->static_link, > > + block = finish_block (newobj->name, newobj->static_link, > > &local_symbols, newobj->old_blocks, > > lowpc, highpc); > > Huh, I actually have a warning I did not notice but not an error, so I > guess you built GDB as C++. Anyway, this is a big mistake that should > have broken the feature I intend to add: quite bad! Thank you very much > for pointing me at it. I built it using GCC's C compiler, but with -Werror enabled. This flag turns warnings into errors. I'll test your new patch today. I've encountered a GDB bug related to examining variables with within a nested function. I'm hoping that your patch will fix it... Kevin