From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41613 invoked by alias); 16 Jul 2015 14:37:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41222 invoked by uid 89); 16 Jul 2015 14:37:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 16 Jul 2015 14:37:56 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 1A0A93187ED; Thu, 16 Jul 2015 14:37:55 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-41.ams2.redhat.com [10.36.116.41]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6GEbpQs014421 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 16 Jul 2015 10:37:53 -0400 Date: Thu, 16 Jul 2015 14:37:00 -0000 From: Jan Kratochvil To: Yao Qi Cc: Pedro Alves , gdb-patches@sourceware.org, Andreas Arnez Subject: Re: ping: [testsuite patch] for: [PATCH] [PR corefiles/17808] i386: Fix internal error when prstatus in core file is too big Message-ID: <20150716143750.GA27870@host1.jankratochvil.net> References: <20150205073758.GA25305@host1.jankratochvil.net> <54D33C45.4010706@redhat.com> <20150214151231.GA29106@host1.jankratochvil.net> <54E33A8D.80504@redhat.com> <20150217165629.GA24936@host1.jankratochvil.net> <55A4CDD1.6060907@gmail.com> <20150714180748.GA13461@host1.jankratochvil.net> <86fv4pjt4m.fsf@gmail.com> <20150715165849.GA12070@host1.jankratochvil.net> <867fq0jijf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <867fq0jijf.fsf@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00472.txt.bz2 On Thu, 16 Jul 2015 16:15:00 +0200, Yao Qi wrote: > Sorry, I should be more clear. Let me ask in another way, why do we > need "x/i $address" test? Without the patch fixing PR 17808, GDB should > crash on loading core-file, and we tested that. Why do we do this test > and test whether ".text" is readable or not? Because this testcase comes from a different bug from 2009: https://bugzilla.redhat.com/show_bug.cgi?id=457187 http://pkgs.fedoraproject.org/cgit/gdb.git/commit/?id=94cd124608bf0dd359cb48a710800d72c21b30c3 That bug has been fixed in the meantime but the same testcase was reproducing this new different bug - internal error regression - so I submitted it. We can remove the "x/i $address" test but it was useful for the previous bug from 2009 as that time the internal error regression did not happen, just the core file was not recognized (which would not be detected by the proposed ignoring of the "core-file" command output) and so the core file was not available. That can be tested by the "x/i $address" test. But we could be upstreaming much more Fedora testcases which I do not plan to. Fedora contains many testcases - 49 grep '^#=' gdb.spec|sed 's/[:+].*//'|sort|uniq -c 49 #=fedoratest for various bugs already fixed upstream. But given there isn't enough work resources to upstream even Fedora fixes (hacks) I have never much attempted to upstream all the testcases there. http://pkgs.fedoraproject.org/cgit/gdb.git/tree/ (Some/few of the testcases are also a different form of the upstreamed variant of the same testcase kept to be really sure no regressions are needlessly missed in Fedora/RHEL.) Jan