On Mon, 08 Jun 2015 10:37:33 +0200, Gary Benson wrote:
> A bunch of stuff has changed in the way common code is laid out since
> May 2014, so while Tom approved this back then, it's not suitable any
> more.  Please update the series as follows:
> 
> > 	* common/linux-maps.c: New file.
> > 	* common/linux-maps.h: New file.
> 
> Nothing os-specific should be in common.  These files should be
> nat/linux-maps.[ch].

While I have done so I do not share this opinion.  linux-maps.[ch] is used
from linux-tdep.c and not from linux-nat.c.  linux-tdep.c is using common/*
files a lot but it uses no function from nat/*:
	$ for i in $(for i in common/*.c;do nm `basename $i .c`.o;done|sed -n 's/^.* T //p');do grep -q "\<$i (" linux-tdep.c && echo $i;done|wc -l
	17
	$ for i in $(for i in    nat/*.c;do nm `basename $i .c`.o;done|sed -n 's/^.* T //p');do grep -q "\<$i (" linux-tdep.c && echo $i;done|wc -l
	0
	(commands above assume in-src-tree build)

Additionally linux-maps.o should not be in config/**.mh::NATDEPFILES (like
linux-namespaces.o from nat/ ) but it needs to be in configure.tgt instead.

Should be linux-maps.[ch] therefore in nat/ or in common/ ?
If it matters, though.


Jan