From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113553 invoked by alias); 12 Jul 2015 21:34:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113540 invoked by uid 89); 12 Jul 2015 21:34:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 X-HELO: mail-wg0-f52.google.com Received: from mail-wg0-f52.google.com (HELO mail-wg0-f52.google.com) (74.125.82.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 12 Jul 2015 21:34:55 +0000 Received: by wgjx7 with SMTP id x7so282509561wgj.2 for ; Sun, 12 Jul 2015 14:34:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=1QW+nTDblCm914+33J1dOBxPDbAsC8RofVpsXmZhYEc=; b=j3TUoietzOIPAWZx/M4dmp4WSI+3osuMlcOgYV3JfrLrSgJPOUjQsyqD/qFjNyf3jg nT6pORvcmFKxwLRIK/QTMj/FJAOVQFl2qF2s3uMNUN4jwChhcNHCktI6azYH23n6M6I4 O/Ee79hVzzl9BkSriJEXQvfNKMUoxrzYcpkBcP5RfoGKXS25NB7QG+KcxJwoB8EuUoDk USF1Dw5TkVlNWKe2Zg0HSyagAaWqHCP9OR5/piU7HxJFtQK84XQlOex1bX7P83QoQRNv PILcTaLBQ7d3FP9Oh4srsgtZVgY/1kKuJAj9XvHQATgv1SNkQpiae2eUlnfyIDBJ26sj ZHrg== X-Gm-Message-State: ALoCoQl6OFVFfPaVpxuQiNNExlyp5Ij6QB83DFeQ83MFpO2E8JPui+Usv+ya+ZYqzXmRAtlnLWTS X-Received: by 10.194.58.7 with SMTP id m7mr59402163wjq.109.1436736892254; Sun, 12 Jul 2015 14:34:52 -0700 (PDT) Received: from localhost (host81-158-4-174.range81-158.btcentralplus.com. [81.158.4.174]) by smtp.gmail.com with ESMTPSA id nb9sm10790979wic.10.2015.07.12.14.34.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 12 Jul 2015 14:34:51 -0700 (PDT) Date: Sun, 12 Jul 2015 21:34:00 -0000 From: Andrew Burgess To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/tui: Add command completion to winheight command. Message-ID: <20150712213449.GA3915@embecosm.com> References: <1436534024-23458-1-git-send-email-andrew.burgess@embecosm.com> <559FF19E.3010208@redhat.com> <20150712085140.GE5485@embecosm.com> <55A280B3.9050503@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55A280B3.9050503@redhat.com> X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00360.txt.bz2 * Pedro Alves [2015-07-12 15:58:59 +0100]: > On 07/12/2015 09:51 AM, Andrew Burgess wrote: > > > gdb/ChangeLog: > > > > * tui/tui-win.c (window_name_completer): New function. > > (focus_completer): Call window_name_completer. All old content > > moved into window_name_completer. > > (winheight_completer): New function. > > (_initialize_tui_win): Rename variable. Add completer to > > winheight command. Update doc string on winheight. > > > > This is OK. > > > -/* Complete possible window names to focus on. TEXT is the complete text > > - entered so far, WORD is the word currently being completed. */ > > +/* Generic window name completion function. Complete window name pointed > > + to by TEXT and WORD. If INCLUDE_NEXT_PREV_P is true then the special > > + window names 'next' and 'prev' are also included in the list of possible > > + completions (if appropriate). */ > > > > I don't really understand what "if appropriate" is referring to, though. I originally wrote "... are also included in the list of possible completions." however, this is not true, if a window name has been partially typed then clearly 'prev' or 'next' might not be included in the list of possible completions (if say the partial window name started with a 'c'). How about this wording: "If INCLUDE_NEXT_PREV_P is true then the special window names 'next' and 'prev' will also be considered as possible completions of the window name." Or feel free to suggest something simpler. Thanks, Andrew