From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 488 invoked by alias); 6 Jul 2015 12:53:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 476 invoked by uid 89); 6 Jul 2015 12:53:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 06 Jul 2015 12:53:58 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id F39CF116373; Mon, 6 Jul 2015 08:53:55 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id BUPBilbiLhQr; Mon, 6 Jul 2015 08:53:55 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id BBD46116372; Mon, 6 Jul 2015 08:53:55 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 65A56406C0; Mon, 6 Jul 2015 05:53:54 -0700 (PDT) Date: Mon, 06 Jul 2015 12:53:00 -0000 From: Joel Brobecker To: Gary Benson Cc: Don Breazeal , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Make only user-specified executable filenames sticky Message-ID: <20150706125354.GC3125@adacore.com> References: <20150505151448.GA1417@blade.nx> <1430907977-30605-1-git-send-email-gbenson@redhat.com> <5550E357.9040209@codesourcery.com> <20150605093724.GA26604@blade.nx> <5571B828.1080208@codesourcery.com> <20150703111418.GB15448@blade.nx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150703111418.GB15448@blade.nx> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-07/txt/msg00117.txt.bz2 > > I think it goes like this: infrun.c:follow_exec calls > > exec.c:exec_file_attach, which updates the name of the executable. > > Ah, there is exactly the scenario you describe Don, good call. > Joel, I can fix v3 of this patch to zero exec_file_is_user_supplied > before the exec_file_attach in follow_exec. > > I'm not convinced this patch will not introduce new bugs, the whole > handling of how/where executable and/or symbol files get changed > seems... haphazard :) That's mainly why I'd put this patch on the > back burner. > > I'm on the fence as to whether this should be committed, so I'll > defer to you Joel. If you say commit I'll re-test and push. Thanks, Gary. Let's not commit a risky patch just before branching, especially for something that's not a regression. So, let's branch first and fix on master afterwards. Later on, if the fix proves solid, and backporting is an option, then we can backport for 7.10 or 7.10.1. -- Joel