Re: [PATCH] Make only user-specified executable filenames sticky

Joel Brobecker
2015-07-06T12:53:59Z

> > I think it goes like this: infrun.c:follow_exec calls
> > exec.c:exec_file_attach, which updates the name of the executable.
>
> Ah, there is exactly the scenario you describe Don, good call.
> Joel, I can fix v3 of this patch to zero exec_file_is_user_supplied
> before the exec_file_attach in follow_exec.
>
> I'm not convinced this patch will not introduce new bugs, the whole
> handling of how/where executable and/or symbol files get changed
> seems... haphazard :) That's mainly why I'd put this patch on the
> back burner.
>
> I'm on the fence as to whether this should be committed, so I'll
> defer to you Joel. If you say commit I'll re-test and push.

Thanks, Gary.

Let's not commit a risky patch just before branching, especially
for something that's not a regression. So, let's branch first and
fix on master afterwards. Later on, if the fix proves solid, and
backporting is an option, then we can backport for 7.10 or 7.10.1.

--
Joel