From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8045 invoked by alias); 2 Jul 2015 13:53:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7506 invoked by uid 89); 2 Jul 2015 13:53:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 02 Jul 2015 13:53:26 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id DDDFCB669D; Thu, 2 Jul 2015 13:53:24 +0000 (UTC) Received: from blade.nx (ovpn-116-52.ams2.redhat.com [10.36.116.52]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t62DrOpG007117; Thu, 2 Jul 2015 09:53:24 -0400 Received: by blade.nx (Postfix, from userid 1000) id A64CD2643E6; Thu, 2 Jul 2015 14:53:23 +0100 (BST) Date: Thu, 02 Jul 2015 13:53:00 -0000 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org, =?iso-8859-1?Q?C=E9dric?= Buissart Subject: Re: [PATCH 1/5] Introduce build_debug_file_name Message-ID: <20150702135323.GA21663@blade.nx> References: <1434447768-17328-1-git-send-email-gbenson@redhat.com> <1434447768-17328-2-git-send-email-gbenson@redhat.com> <5593C985.7020204@redhat.com> <20150702111821.GA17978@blade.nx> <559522CB.5080403@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <559522CB.5080403@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00077.txt.bz2 Pedro Alves wrote: > On 07/02/2015 12:18 PM, Gary Benson wrote: > > Pedro Alves wrote: > > > On 06/16/2015 10:42 AM, Gary Benson wrote: > > > > This commit introduces a new function build_debug_file_name > > > > which concatenates a series of filename components into a > > > > filename. find_separate_debug_file is updated to use > > > > build_debug_file_name. A later commit in this series will > > > > extend build_debug_file_name to correctly handle "target:" > > > > prefixes, so it is convenient to have filename building pulled > > > > out into one function. For now the only functional change > > > > here is that the original code sometimes generated filenames > > > > with repeated directory separators while the new code does > > > > not. > > > > > > I'd drop the "debug" from the function's name. Sounds like a > > > candidate for reuse elsewhere to me. > > > > Should I put it somewhere else, maybe common-utils.c? > > I dislike common-utils.c for "kitchen-sink" reasons, though. > > There's common/filestuff.c, but that looks more for low/OS level > file things. Yeah, that was my first thought. > There's substitute_path_component (and gdb_realpath / gdb_abspath) > in utils.c. Maybe put it next to substitute_path_component, which > seems to be in the same "family" of function, and then (at some > point) we would move all file name/path manipulation routines to its > own file. > > WDYT? Suits me :) Cheers, Gary -- http://gbenson.net/