From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11285 invoked by alias); 24 Jun 2015 10:31:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11275 invoked by uid 89); 24 Jun 2015 10:31:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 24 Jun 2015 10:31:17 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 63A1619F982; Wed, 24 Jun 2015 10:31:16 +0000 (UTC) Received: from blade.nx (ovpn-116-95.ams2.redhat.com [10.36.116.95]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5OAVFCt009901; Wed, 24 Jun 2015 06:31:16 -0400 Received: by blade.nx (Postfix, from userid 1000) id 00F022642CB; Wed, 24 Jun 2015 11:31:14 +0100 (BST) Date: Wed, 24 Jun 2015 10:31:00 -0000 From: Gary Benson To: Mike Frysinger Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdb: sim: handle target sysroot prefix Message-ID: <20150624103114.GB11787@blade.nx> References: <1434910105-7023-1-git-send-email-vapier@gentoo.org> <1435073379-30787-1-git-send-email-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435073379-30787-1-git-send-email-vapier@gentoo.org> X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00515.txt.bz2 Mike Frysinger wrote: > The default gdb sysroot now sets itself to "target:". This works > for most remote targets, but when using the simulator, this causes > problems as the sim will attempt to search for that path. > > Update the remote-sim logic to skip this leading prefix when it is > found so that the sysroot isn't passed in as an invalid value. > > 2015-06-21 Mike Frysinger > > * remote-sim.c: Include gdb_bfd.h. > (gdbsim_open): Declare new local sysroot pointing to gdb_sysroot. > Skip TARGET_SYSROOT_PREFIX in gdb_sysroot when it is active. Looks good to me :) Cheers, Gary -- http://gbenson.net/