From: Gary Benson <gbenson@redhat.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: sim: handle target sysroot prefix
Date: Wed, 24 Jun 2015 10:30:00 -0000 [thread overview]
Message-ID: <20150624103025.GA11787@blade.nx> (raw)
In-Reply-To: <20150623152826.GG17734@vapier>
Mike Frysinger wrote:
> On 22 Jun 2015 10:50, Gary Benson wrote:
> > Please note that gdb_sysroot can be NULL.
>
> how so ? main.c:captured_main specifically handles that:
>
> /* Set the sysroot path. */
> gdb_sysroot = relocate_gdb_directory (TARGET_SYSTEM_ROOT,
> TARGET_SYSTEM_ROOT_RELOCATABLE);
>
> if (gdb_sysroot == NULL || *gdb_sysroot == '\0')
> {
> xfree (gdb_sysroot);
> gdb_sysroot = xstrdup (TARGET_SYSROOT_PREFIX);
> }
Good point. I may go and clear out all the gdb_sysroot == NULL
checks.
Cheers,
Gary
--
http://gbenson.net/
next prev parent reply other threads:[~2015-06-24 10:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-21 18:08 Mike Frysinger
2015-06-22 9:50 ` Gary Benson
2015-06-23 15:28 ` Mike Frysinger
2015-06-24 10:30 ` Gary Benson [this message]
2015-06-25 8:35 ` [OB PATCH] Remove gdb_sysroot NULL checks Gary Benson
2015-06-23 15:29 ` [PATCH] gdb: microblaze: delete useless stubs Mike Frysinger
2015-06-23 15:31 ` Mike Frysinger
2015-06-23 17:39 ` Michael Eager
2015-06-23 15:29 ` [PATCH v2] gdb: sim: handle target sysroot prefix Mike Frysinger
2015-06-24 10:31 ` Gary Benson
2015-06-24 13:47 ` Pedro Alves
2015-06-24 14:32 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150624103025.GA11787@blade.nx \
--to=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox