From: Gary Benson <gbenson@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Aleksandar Ristovski <ARistovski@qnx.com>
Subject: Re: [PATCH v6 04/10] Create empty common/linux-maps.[ch] and common/target-utils.[ch]
Date: Tue, 23 Jun 2015 08:42:00 -0000 [thread overview]
Message-ID: <20150623084023.GA16976@blade.nx> (raw)
In-Reply-To: <20150614192840.GA18460@host1.jankratochvil.net>
Jan Kratochvil wrote:
> On Mon, 08 Jun 2015 10:37:33 +0200, Gary Benson wrote:
> > Nothing to do with the target should be in common. The
> > declarations should probably be in target/target.h, and
> > they should have "target_" prefixes. You could create
> > target/target.c to put the definitions in.
>
> Created target/target-utils.c as we discussed elsewhere.
>
> > > diff --git a/gdb/common/linux-maps.c b/gdb/common/linux-maps.c
> > ...
> > > +
> > > +#ifdef GDBSERVER
> > > +#include "server.h"
> > > +#else
> > > +#include "defs.h"
> > > +#endif
> > > +
> > > +#include "linux-maps.h"
> >
> > This should be:
> >
> > #include "common-defs.h"
> > #include "linux-maps.h"
>
> Done.
>
> > On a separate but related note, please do not add GDBSERVER
> > conditionals anywhere, I spent half a year removing almost
> > all of them and the remaining couple are on my hit list.
>
> Done.
Thanks Jan.
Cheers,
Gary
--
http://gbenson.net/
next prev parent reply other threads:[~2015-06-23 8:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-07 20:04 [PATCH v6 00/10] Validate binary before use Jan Kratochvil
2015-06-07 20:04 ` [PATCH v6 02/10] Merge multiple hex conversions Jan Kratochvil
2015-06-07 20:04 ` [PATCH v6 03/10] Code cleanup: Rename enum -> enum filterflags Jan Kratochvil
2015-06-08 2:39 ` Sergio Durigan Junior
2015-06-07 20:04 ` [PATCH v6 01/10] Move utility functions to common/ Jan Kratochvil
2015-06-07 20:05 ` [PATCH v6 05/10] Move gdb_regex* " Jan Kratochvil
2015-06-07 20:05 ` [PATCH v6 10/10] Tests for validate symbol file using build-id Jan Kratochvil
2015-06-07 20:05 ` [PATCH v6 09/10] Validate " Jan Kratochvil
2015-06-07 20:05 ` [PATCH v6 07/10] Move linux_find_memory_regions_full & co Jan Kratochvil
2015-06-08 8:42 ` Gary Benson
2015-06-07 20:05 ` [PATCH v6 06/10] Prepare linux_find_memory_regions_full & co. for move Jan Kratochvil
2015-06-07 20:05 ` [PATCH v6 08/10] gdbserver build-id attribute generator Jan Kratochvil
2015-06-07 20:05 ` [PATCH v6 04/10] Create empty common/linux-maps.[ch] and common/target-utils.[ch] Jan Kratochvil
2015-06-08 8:37 ` Gary Benson
2015-06-11 18:48 ` Jan Kratochvil
2015-06-11 19:47 ` Aleksandar Ristovski
2015-06-12 11:26 ` Gary Benson
2015-06-14 19:28 ` Jan Kratochvil
2015-06-23 8:42 ` Gary Benson [this message]
2015-07-15 21:20 ` [PATCH v10 " Jan Kratochvil
2015-07-16 8:14 ` Gary Benson
2015-07-16 8:32 ` Jan Kratochvil
2015-07-21 10:28 ` Pedro Alves
2015-07-17 20:51 ` [PATCH v11 " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623084023.GA16976@blade.nx \
--to=gbenson@redhat.com \
--cc=ARistovski@qnx.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox