From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103601 invoked by alias); 22 Jun 2015 04:56:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103502 invoked by uid 89); 22 Jun 2015 04:56:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 22 Jun 2015 04:56:12 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 972AA340B5D; Mon, 22 Jun 2015 04:56:10 +0000 (UTC) Date: Mon, 22 Jun 2015 04:56:00 -0000 From: Mike Frysinger To: Michael Eager Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: microblaze: delete useless stubs Message-ID: <20150622045610.GE17734@vapier> Mail-Followup-To: Michael Eager , gdb-patches@sourceware.org References: <1434910383-18403-1-git-send-email-vapier@gentoo.org> <5587124B.5010504@eagerm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="F8dlzb82+Fcn6AgP" Content-Disposition: inline In-Reply-To: <5587124B.5010504@eagerm.com> X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00429.txt.bz2 --F8dlzb82+Fcn6AgP Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 854 On 21 Jun 2015 12:36, Michael Eager wrote: > On 06/21/2015 11:13 AM, Mike Frysinger wrote: > > These don't accomplish anything the common core doesn't already, so > > punt them as they purely waste code. > > > > 2015-06-21 Mike Frysinger > > > > * microblaze-tdep.c (microblaze_push_dummy_code): Delete. > > (microblaze_push_dummy_call): Likewise. > > (microblaze_gdbarch_init): Delete calls to set_gdbarch_push_dummy_code > > and set_gdbarch_push_dummy_call. >=20 > Does the common code issue an error if someone tries > to call a target function? yes gdb/infcall.c: struct value * call_function_by_hand_dummy (struct value *function, ... if (!gdbarch_push_dummy_call_p (gdbarch)) error (_("This target does not support function calls.")); $ ./gdb ... (gdb) p foo(1) This target does not support function calls. -mike --F8dlzb82+Fcn6AgP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVh5VqAAoJEEFjO5/oN/WBolwP/2xj9zcgvwoB2awv91a+29px diHkK9A3M+nSYiQ/6iQi9Bdsdgaa+jCtcIR7cicXCdPaD56k8ADkgKg5/+aO/tVT 2EUUBgTNYWr2tirB/Drclgr0nF4gF/pyXnaBvIofH0qGO/XSZbSV+YUh0Vo1X0ds oKlH/t3w9esXTiWdXPIghKU9SmPti6uAxrNXgtMgGT4Ed8NFyeA93YK0HZjuQS0j 7GC9GpkBEWaccDqFE2YfdZrW6Tr2c1wo2PazPMw9ly9bnNhvzIytHNavwYLwg8Zn YSFbosLFfeKadNdIIHaExMJTysFNORMhh0uMnEPSdKDF78hbj8+AEO+MI1MBp/5v 32jEcV1BFSvm2etc6Wp0Lc+yMdDDJYSj7vgWVGvEVX4TPVQ9TqtpRGSMrpXpoGeF xuISYdqgZuZXAr6+4hOt+YUSdn7z/yiBeE8lDEF2MQRgjAL5lj02QGzbtO86Wooh atgpEJt0pWVA75vF0HHqXynxUhLSRTqVtv1mGfkG+A+vr/FSzH2hT5x85rY6tj/P eZOBwa4/PeypT1ppSwlrPWl+nk7ckpcO8I7lmoj/oaWj7RAwUTqDv9AupDWAudez vOnC14LiPTdjrN1q+4U87M2Y/PTjZV8PIvHv1o2/6aS/Bomwf3KlqAq6y7E41XdB hNT28TqaJbjPNJOw+z5+ =vph+ -----END PGP SIGNATURE----- --F8dlzb82+Fcn6AgP--