From: Mike Frysinger <vapier@gentoo.org>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] sim: cgen: namespace custom trace functions
Date: Sun, 21 Jun 2015 18:40:00 -0000 [thread overview]
Message-ID: <20150621184030.GA17734@vapier> (raw)
In-Reply-To: <CADPb22TYHgvAQW7emmueSPLp2FT5oezXMci9CxVc1s0Zq-YQmw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]
On 14 Jun 2015 06:49, Doug Evans wrote:
> On Fri, Jun 12, 2015 at 2:11 AM, Mike Frysinger wrote:
> > The cgen code declares some macros/funcs using the trace_xxx prefix, but
> > the code isn't generic and only works with cgen targets. This is blocking
> > the creation of new common trace functions.
> >
> > Let's blindly add cgen_xxx prefixes to all these symbols. Some already
> > use this convention to avoid conflicts, so it makes sense to align them.
> > In the future we might want to move some to the common trace core, but
> > one thing at a time.
> >
> > I'm attaching the patch compressed because it's like 2MB in size. It's
> > all pretty mechanical -- the large files were updated using `sed`.
> >
> > Committed.
>
> Heads up, a lot of these are generated files.
> I'm happy to update the generator and regenerate these.
sorry about that. i'm not terribly familiar with cgen, and the heavy use of
scheme makes it unlikely to improve the situation :/. looks like you posted
a patch though at this point.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-06-21 18:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 9:11 Mike Frysinger
2015-06-14 13:49 ` Doug Evans
2015-06-21 18:40 ` Mike Frysinger [this message]
2015-06-22 14:10 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150621184030.GA17734@vapier \
--to=vapier@gentoo.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox