From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79132 invoked by alias); 18 Jun 2015 10:55:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 78989 invoked by uid 89); 18 Jun 2015 10:55:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 18 Jun 2015 10:55:31 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 18A4B8F28E; Thu, 18 Jun 2015 10:55:30 +0000 (UTC) Received: from blade.nx (ovpn-116-89.ams2.redhat.com [10.36.116.89]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5IAtT17010628; Thu, 18 Jun 2015 06:55:29 -0400 Received: by blade.nx (Postfix, from userid 1000) id AF544262FE6; Thu, 18 Jun 2015 11:55:28 +0100 (BST) Date: Thu, 18 Jun 2015 10:55:00 -0000 From: Gary Benson To: Eli Zaretskii Cc: gdb-patches@sourceware.org, cedric.buissart@gmail.com Subject: Re: [PATCH 1/5] Introduce build_debug_file_name Message-ID: <20150618105528.GA2644@blade.nx> References: <1434447768-17328-1-git-send-email-gbenson@redhat.com> <1434447768-17328-2-git-send-email-gbenson@redhat.com> <83zj3zn21q.fsf@gnu.org> <20150617094734.GA9671@blade.nx> <83a8vymgmg.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83a8vymgmg.fsf@gnu.org> X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00383.txt.bz2 Eli Zaretskii wrote: > > Date: Wed, 17 Jun 2015 10:47:34 +0100 > > From: Gary Benson > > Cc: gdb-patches@sourceware.org, cedric.buissart@gmail.com > > > > For the case you mention nothing would be stripped (the "d" in > > that path is !IS_DIR_SEPARATOR) so the filename components would > > be concatenated verbatim, just as with the original code. The > > resulting filename may not make sense, but it's not a regression. > > But won't we produce "d://foo/bar" as result? No. build_debug_file_name strips both leading and trailing slashes. The only ways to get a double slash from build_debug_file_name is to pass one in in the middle of a string. build_debug_file_name ("d:", "foo", "bar") -> "d:/foo/bar" build_debug_file_name ("d:/", "/foo", "bar") -> "d:/foo/bar" build_debug_file_name ("d:///", "///foo///", "bar") -> "d:/foo/bar" but build_debug_file_name("d://foo", "bar") -> "d://foo/bar" > > I don't believe this series should be blocked unless it breaks > > something that actually worked before. > > If a fix is very simple, why not make it? I don't understand, what are you asking me to fix? Thanks, Gary -- http://gbenson.net/