From: Martin Simmons <martin@lispworks.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix compilation of gdb/arm-linux-nat.c on Raspbian GNU/Linux 7
Date: Mon, 15 Jun 2015 16:32:00 -0000 [thread overview]
Message-ID: <201506151632.t5FGWEOb023695@higson.cam.lispworks.com> (raw)
In-Reply-To: <557ECC66.5060606@gmail.com> (message from Yao Qi on Mon, 15 Jun 2015 14:00:22 +0100)
>>>>> On Mon, 15 Jun 2015 14:00:22 +0100, Yao Qi said:
>
> This patch is OK, except for the ChangeLog entry, it can be rewritten like
>
> On 15/06/15 13:43, Martin Simmons wrote:
> > gdb/ChangeLog
> >
> > * arm-linux-nat.c (nat/linux-ptrace.h): New include for
> > PTRACE_GETREGSET et al in case of old system header files.
>
> * arm-linux-nat.c: Include nat/linux-ptrace.h.
>
> because we put what do we change in the changelog rather than "why".
OK.
> Do you have the commit access to gdb git repository?
No.
__Martin
next prev parent reply other threads:[~2015-06-15 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-15 12:43 Martin Simmons
2015-06-15 13:00 ` Yao Qi
2015-06-15 16:32 ` Martin Simmons [this message]
2015-06-16 8:42 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201506151632.t5FGWEOb023695@higson.cam.lispworks.com \
--to=martin@lispworks.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox