From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58473 invoked by alias); 15 Jun 2015 13:33:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58464 invoked by uid 89); 15 Jun 2015 13:33:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 15 Jun 2015 13:33:13 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id CD69A289A0; Mon, 15 Jun 2015 09:33:11 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3crP2ReyHZ1d; Mon, 15 Jun 2015 09:33:11 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 94E51D3C65; Mon, 15 Jun 2015 09:33:11 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 40245406D9; Mon, 15 Jun 2015 06:33:10 -0700 (PDT) Date: Mon, 15 Jun 2015 13:33:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Aleksandar Ristovski Subject: Re: [PATCH v7 02/10] Merge multiple hex conversions Message-ID: <20150615133310.GC25717@adacore.com> References: <20150614192542.18346.87859.stgit@host1.jankratochvil.net> <20150614192559.18346.31036.stgit@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150614192559.18346.31036.stgit@host1.jankratochvil.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-06/txt/msg00303.txt.bz2 > gdb/gdbserver/ChangeLog > 2014-02-26 Aleksandar Ristovski Jan Kratochvil > > Merge multiple hex conversions. > * gdbreplay.c (tohex): Rename to 'fromhex'. > (logchar): Use fromhex. I hesitated on this one, since I was wondering why we have two implementations of fromhex, one there, and one in rsp-low.c. I'm guessing it's because this on in gdbreplay has a call to "exit" (!!!). But, in the end, it seems to me that this patch is already an improvement over the previous situation, and I'm not really sure of the reasons behind the current implementation, so we can leave this as is for now. (FTAOD: this is OK). > gdb/ChangeLog > 2014-02-26 Aleksandar Ristovski Jan Kratochvil > > Merge multiple hex conversions. > * monitor.c: Include rsp-low.h. > (fromhex): Remove definition. OK. -- Joel