From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85817 invoked by alias); 14 Jun 2015 19:28:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85808 invoked by uid 89); 14 Jun 2015 19:28:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 14 Jun 2015 19:28:47 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 2E3082B6497; Sun, 14 Jun 2015 19:28:46 +0000 (UTC) Received: from host1.jankratochvil.net (ovpn-116-41.ams2.redhat.com [10.36.116.41]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5EJSeXc016967 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 14 Jun 2015 15:28:44 -0400 Date: Sun, 14 Jun 2015 19:28:00 -0000 From: Jan Kratochvil To: Gary Benson Cc: gdb-patches@sourceware.org, Aleksandar Ristovski Subject: Re: [PATCH v6 04/10] Create empty common/linux-maps.[ch] and common/target-utils.[ch] Message-ID: <20150614192840.GA18460@host1.jankratochvil.net> References: <20150607200422.8918.48900.stgit@host1.jankratochvil.net> <20150607200454.8918.52868.stgit@host1.jankratochvil.net> <20150608083733.GA5405@blade.nx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150608083733.GA5405@blade.nx> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00292.txt.bz2 On Mon, 08 Jun 2015 10:37:33 +0200, Gary Benson wrote: > Nothing to do with the target should be in common. The declarations > should probably be in target/target.h, and they should have "target_" > prefixes. You could create target/target.c to put the definitions in. Created target/target-utils.c as we discussed elsewhere. > > diff --git a/gdb/common/linux-maps.c b/gdb/common/linux-maps.c > ... > > + > > +#ifdef GDBSERVER > > +#include "server.h" > > +#else > > +#include "defs.h" > > +#endif > > + > > +#include "linux-maps.h" > > This should be: > > #include "common-defs.h" > #include "linux-maps.h" Done. > On a separate but related note, please do not add GDBSERVER > conditionals anywhere, I spent half a year removing almost > all of them and the remaining couple are on my hit list. Done. Jan