From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73345 invoked by alias); 12 Jun 2015 11:26:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73333 invoked by uid 89); 12 Jun 2015 11:26:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 12 Jun 2015 11:26:27 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id AC489C79FD; Fri, 12 Jun 2015 11:26:25 +0000 (UTC) Received: from blade.nx (ovpn-116-89.ams2.redhat.com [10.36.116.89]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5CBQOnm012447; Fri, 12 Jun 2015 07:26:25 -0400 Received: by blade.nx (Postfix, from userid 1000) id 83C3D262FE6; Fri, 12 Jun 2015 12:26:23 +0100 (BST) Date: Fri, 12 Jun 2015 11:26:00 -0000 From: Gary Benson To: Aleksandar Ristovski Cc: Jan Kratochvil , "gdb-patches@sourceware.org" Subject: Re: [PATCH v6 04/10] Create empty common/linux-maps.[ch] and common/target-utils.[ch] Message-ID: <20150612112623.GA2590@blade.nx> References: <20150607200422.8918.48900.stgit@host1.jankratochvil.net> <20150607200454.8918.52868.stgit@host1.jankratochvil.net> <20150608083733.GA5405@blade.nx> <20150611184842.GA14293@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00248.txt.bz2 Aleksandar Ristovski wrote: > On 2015-06-11, 2:48 PM, "Jan Kratochvil" wrote: > >On Mon, 08 Jun 2015 10:37:33 +0200, Gary Benson wrote: > > > Jan Kratochvil wrote: > > > > * common/target-utils.c: New file. > > > > * common/target-utils.h: New file. > > > > > > Nothing to do with the target should be in common. The > > > declarations should probably be in target/target.h, and they > > > should have "target_" prefixes. You could create > > > target/target.c to put the definitions in. > > > > gdb/target/target.c would create target.o which would conflict > > with gdb/target.c. > > > > There is already gdb/target/target.h "conflicting" with > > gdb/target.h but it does not really conflict as gdb/target/ does > > not have default -I include dir. Despite for example gdb/common/ > > has default -I. -Igdb/common is going to be removed at some stage. I have a script to do it, I just didn't ever get around to it. Maybe once 7.10 is released... > > I could propose various ideas what to move there but what is the > > suggested solution? Sure one could also for example just generate > > gdb/target-target.o from gdb/target/target.c. > > As you say, there could be various ideas if needed, but the simplest > seems good enough to me: just move the files to target dir > > common/target-utils.[hc] -> target/target_utils.[hc] > > Provided Gary is happy with that solution. Works for me :) Thanks, Gary -- http://gbenson.net/