From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27606 invoked by alias); 9 Jun 2015 18:23:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27594 invoked by uid 89); 9 Jun 2015 18:23:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 09 Jun 2015 18:23:38 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 6544828B50; Tue, 9 Jun 2015 14:23:36 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 0HmC94zO+M+h; Tue, 9 Jun 2015 14:23:36 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 54E0728AFA; Tue, 9 Jun 2015 14:23:36 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id D33C04067C; Tue, 9 Jun 2015 14:23:35 -0400 (EDT) Date: Tue, 09 Jun 2015 18:23:00 -0000 From: Joel Brobecker To: Walfred Tedeschi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3] Improve test for processor feature om MPX registers test. Message-ID: <20150609182335.GC2855@adacore.com> References: <1433779534-32677-1-git-send-email-walfred.tedeschi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433779534-32677-1-git-send-email-walfred.tedeschi@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-06/txt/msg00144.txt.bz2 On Mon, Jun 08, 2015 at 06:05:34PM +0200, Walfred Tedeschi wrote: > Skips the MPX register test in case target is not Intel. > Improves the test for MPX feature making MPX and AVX512 > tests more similar in terms of initialization. > Indentation was improved on sample file and final return added > to have_mpx. On test file identation was improved and > gdb_send was exchanged by gdb_test_multiple. > > 2015-06-08 Walfred Tedeschi > > gdb/testsuite > * gdb.arch/i386-mpx.c: Added final return to the have_mpx > function and improved indentation. > * gdb.arch/i386-mpx.exp: Exchanging gdb_send and gdb_expect for > gdb_test_multiple. Added additional tests to skip the test. Approved. Thanks for the use of gdb_test_multiple in place of send_gdb + gdb_expect ! -- Joel