Re: [PATCH 4/7] Remove linux_proc_pid_get_ns

Gary Benson
2015-04-17T13:44:44Z

Doug Evans wrote:
> On Thu, Apr 16, 2015 at 5:19 AM, Gary Benson <gbenson@redhat.com> wrote:
> > This commit removes linux_proc_pid_get_ns, and updates its only
> > use to use linux_ns_same instead.
> >
> > gdb/ChangeLog:
> >
> > * linux-thread-db.c (nat/linux-namespaces.h): New include.
> > (check_pid_namespace_match): Use linux_ns_same rather than
> > linux_proc_pid_get_ns to spot PID namespace mismatches.
> > * nat/linux-procfs.h (linux_proc_pid_get_ns): Remove.
> > * nat/linux-procfs.c (linux_proc_pid_get_ns): Likewise.
>
> LGTM.
> one nit below
[snip]
> I see we're using pid_t here.
> I think we talked before about a type for pids.
> Since this is all linux specific code maybe use pid_t more in this
> patch set?

I could do that. It would likely only be in linux-namespaces.[ch]
and maybe one or two places in linux-nat.c, all the other stuff is
in the target vectors.

Cheers,
Gary

--