From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29011 invoked by alias); 8 Jun 2015 08:42:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28999 invoked by uid 89); 8 Jun 2015 08:42:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 08 Jun 2015 08:42:30 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 511FF19F996; Mon, 8 Jun 2015 08:42:29 +0000 (UTC) Received: from blade.nx (ovpn-116-112.ams2.redhat.com [10.36.116.112]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t588gSFn027381; Mon, 8 Jun 2015 04:42:29 -0400 Received: by blade.nx (Postfix, from userid 1000) id F3EE02626FA; Mon, 8 Jun 2015 09:42:27 +0100 (BST) Date: Mon, 08 Jun 2015 08:42:00 -0000 From: Gary Benson To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Aleksandar Ristovski Subject: Re: [PATCH v6 07/10] Move linux_find_memory_regions_full & co. Message-ID: <20150608084227.GB5405@blade.nx> References: <20150607200422.8918.48900.stgit@host1.jankratochvil.net> <20150607200518.8918.94373.stgit@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150607200518.8918.94373.stgit@host1.jankratochvil.net> X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00109.txt.bz2 Jan Kratochvil wrote: > diff --git a/gdb/common/linux-maps.c b/gdb/common/linux-maps.c > index bb3eac9..462a00f 100644 > --- a/gdb/common/linux-maps.c > +++ b/gdb/common/linux-maps.c > @@ -18,8 +18,529 @@ > > #ifdef GDBSERVER > #include "server.h" > +#include > +#include > #else > #include "defs.h" > +#include "target.h" > #endif > > #include "linux-maps.h" > +#include "gdb_assert.h" > +#include > +#include > +#include "target-utils.h" > +#include "gdb_regex.h" In addition to the comment I made previously about not using GDBSERVER conditionals, please note that common-defs.h includes gdb_assert.h and string.h, so these two headers should not be listed here. > diff --git a/gdb/common/target-utils.c b/gdb/common/target-utils.c > index 308996d..ab8991d 100644 > --- a/gdb/common/target-utils.c > +++ b/gdb/common/target-utils.c > @@ -23,4 +23,84 @@ > #include "defs.h" > #endif > > +#include > #include "target-utils.h" > +#include "gdb_assert.h" Ditto. Cheers, Gary -- http://gbenson.net/