Re: [PATCH v6 03/10] Code cleanup: Rename enum -> enum filterflags

Sergio Durigan Junior
2015-06-08T02:39:28Z

On Sunday, June 07 2015, Jan Kratochvil wrote:

> Hi Sergio,
>
> this is an unrelated cleanup, bit mask ints are better to make enums as GDB
> already has support to automatically decode them:
>
> before this patch:
> (gdb) p filterflags
> $1 = 51
> (gdb) p/x filterflags
> $2 = 0x33
>
> after this patch:
> (gdb) p filterflags
> $1 = (COREFILTER_ANON_PRIVATE | COREFILTER_ANON_SHARED | COREFILTER_ELF_HEADERS | COREFILTER_HUGETLB_PRIVATE)
>
> New patch, not yet reviewed before.

Hello Jan,

Thanks for the patch. I agree with it, of course.

> gdb/ChangeLog
> 2015-06-07 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * linux-tdep.c (enum filterflags): Make it from anonymous enum.
> (dump_mapping_p): Use it for parameter filterflags.
> (linux_find_memory_regions_full): Use it for variable filterflags.
> ---
> gdb/linux-tdep.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c
> index 8ce2f34..b0981f5 100644
> --- a/gdb/linux-tdep.c
> +++ b/gdb/linux-tdep.c
> @@ -46,7 +46,7 @@
> Documentation/filesystems/proc.txt, inside the Linux kernel
> tree. */
>
> -enum
> +enum filterflags
> {
> COREFILTER_ANON_PRIVATE = 1 << 0,
> COREFILTER_ANON_SHARED = 1 << 1,
> @@ -598,7 +598,7 @@ mapping_is_anonymous_p (const char *filename)
> This should work OK enough, however. */
>
> static int
> -dump_mapping_p (unsigned int filterflags, const struct smaps_vmflags *v,
> +dump_mapping_p (enum filterflags filterflags, const struct smaps_vmflags *v,
> int maybe_private_p, int mapping_anon_p, int mapping_file_p,
> const char *filename)
> {
> @@ -1119,10 +1119,10 @@ linux_find_memory_regions_full (struct gdbarch *gdbarch,
> /* Default dump behavior of coredump_filter (0x33), according to
> Documentation/filesystems/proc.txt from the Linux kernel
> tree. */
> - unsigned int filterflags = (COREFILTER_ANON_PRIVATE
> - | COREFILTER_ANON_SHARED
> - | COREFILTER_ELF_HEADERS
> - | COREFILTER_HUGETLB_PRIVATE);
> + enum filterflags filterflags = (COREFILTER_ANON_PRIVATE
> + | COREFILTER_ANON_SHARED
> + | COREFILTER_ELF_HEADERS
> + | COREFILTER_HUGETLB_PRIVATE);
>
> /* We need to know the real target PID to access /proc. */
> if (current_inferior ()->fake_pid_p)

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible