Re: [PATCH v6 04/10] Create empty common/linux-maps.[ch] and common/target-utils.[ch]

Jan Kratochvil
2015-06-14T19:28:48Z

On Mon, 08 Jun 2015 10:37:33 +0200, Gary Benson wrote:
> Nothing to do with the target should be in common. The declarations
> should probably be in target/target.h, and they should have "target_"
> prefixes. You could create target/target.c to put the definitions in.

Created target/target-utils.c as we discussed elsewhere.

> > diff --git a/gdb/common/linux-maps.c b/gdb/common/linux-maps.c
> ...
> > +
> > +#ifdef GDBSERVER
> > +#include "server.h"
> > +#else
> > +#include "defs.h"
> > +#endif
> > +
> > +#include "linux-maps.h"
>
> This should be:
>
> #include "common-defs.h"
> #include "linux-maps.h"

Done.

> On a separate but related note, please do not add GDBSERVER
> conditionals anywhere, I spent half a year removing almost
> all of them and the remaining couple are on my hit list.

Done.

Jan