Re: [PATCH v6 04/10] Create empty common/linux-maps.[ch] and common/target-utils.[ch]

Jan Kratochvil
2015-06-11T18:48:52Z

On Mon, 08 Jun 2015 10:37:33 +0200, Gary Benson wrote:
> Jan Kratochvil wrote:
> > * common/target-utils.c: New file.
> > * common/target-utils.h: New file.
>
> Nothing to do with the target should be in common. The declarations
> should probably be in target/target.h, and they should have "target_"
> prefixes. You could create target/target.c to put the definitions in.

gdb/target/target.c would create target.o which would conflict with
gdb/target.c.

There is already gdb/target/target.h "conflicting" with gdb/target.h but it
does not really conflict as gdb/target/ does not have default -I include dir.
Despite for example gdb/common/ has default -I.

I could propose various ideas what to move there but what is the suggested
solution? Sure one could also for example just generate gdb/target-target.o
from gdb/target/target.c.

Jan