From: Martin Simmons <martin@lispworks.com>
To: gdb-patches@sourceware.org
Subject: [PATCH] Prevent internal-error when computing $pc in ARM assembly code
Date: Wed, 20 May 2015 09:49:00 -0000 [thread overview]
Message-ID: <201505200949.t4K9nlqt015737@heapu.cam.lispworks.com> (raw)
This patch prevents a gdb internal-error when computing $pc for ARM assembly
code that doesn't use the normal stack frame convention.
It might also help with gdb/12223.
I'm not subscribed to the list so please include me on any replies.
gdb/ChangeLog:
* arm-tdep.c (arm_analyze_prologue): Read memory without throwing an
exception, to allow debugging of assembly code.
diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index 8181f25..d47b4af 100644
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -1669,8 +1669,11 @@ arm_analyze_prologue (struct gdbarch *gdbarch,
current_pc < prologue_end;
current_pc += 4)
{
- unsigned int insn
- = read_memory_unsigned_integer (current_pc, 4, byte_order_for_code);
+ unsigned int insn;
+ gdb_byte buf[4];
+ if (target_read_memory (current_pc, buf, 4))
+ break;
+ insn = extract_unsigned_integer (buf, 4, byte_order_for_code);
if (insn == 0xe1a0c00d) /* mov ip, sp */
{
next reply other threads:[~2015-05-20 9:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 9:49 Martin Simmons [this message]
2015-06-09 18:44 ` Joel Brobecker
2015-06-11 17:25 ` Martin Simmons
2015-06-12 13:21 ` Joel Brobecker
2015-06-12 15:09 ` Martin Simmons
2015-06-12 17:58 ` Joel Brobecker
2015-06-15 10:02 ` Yao Qi
2015-06-15 13:36 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201505200949.t4K9nlqt015737@heapu.cam.lispworks.com \
--to=martin@lispworks.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox