From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4389 invoked by alias); 15 May 2015 13:19:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4374 invoked by uid 89); 15 May 2015 13:19:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 15 May 2015 13:19:18 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4FDJHCv012931 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 15 May 2015 09:19:17 -0400 Received: from blade.nx (ovpn-116-66.ams2.redhat.com [10.36.116.66]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4FDJGJL003266; Fri, 15 May 2015 09:19:16 -0400 Received: by blade.nx (Postfix, from userid 1000) id 0ADDA26404E; Fri, 15 May 2015 14:19:15 +0100 (BST) Date: Fri, 15 May 2015 13:19:00 -0000 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Move vgdb special case into remote_filesystem_is_local Message-ID: <20150515131915.GA22794@blade.nx> References: <1430146276-15606-1-git-send-email-gbenson@redhat.com> <55547C8B.5050000@redhat.com> <20150515090211.GA13085@blade.nx> <5555D94D.6020606@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5555D94D.6020606@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00383.txt.bz2 Pedro Alves wrote: > On 05/15/2015 10:02 AM, Gary Benson wrote: > > Pedro Alves wrote: > > > On 04/27/2015 03:51 PM, Gary Benson wrote: > > > > Valgrind GDB (vgdb) presents itself as a remote target but > > > > works on the local filesystem. gdb_bfd_open contained a > > > > special case to make vgdb work with "target:" sysroots, but > > > > the implementation meant that GDB would fall back to the local > > > > filesystem if *any* to_fileio_open method failed with ENOSYS > > > > for *any* reason. > > > > > > Can you give an example target where we'd want this to behave > > > differently? > > > > > > E.g,. what should happen with "target sim" ? > > > > I don't understand what you're asking. "target sim" doesn't use > > remote_filesystem_is_local, (to_filesystem_is_local for sim is the > > default, tdefault_filesystem_is_local, which returns 1 always). > > When you say: > > gdb_bfd_open contained a special case > to make vgdb work with "target:" sysroots, but the implementation > meant that GDB would fall back to the local filesystem if *any* > to_fileio_open method failed with ENOSYS for *any* reason. > > I'd prefer to get an example target for one of those "if *any* > to_fileio_open ... *any* reason". I'd like to understand the > real motivation for the change. Because otherwise I get to > wonder why would we handle any other target that goes through > this path differently. Ah, ok, I get what you're asking. In what's upstream right now, the only path (I think) that you can get to the point in gdb_bfd_open with the workaround is if you're using a remote target that doesn't support file retrieval. But, in the namespace-awareness series I posted, target_fileio_open can fail with ENOSYS if setns is not available. That's the reason I made the change. Thanks, Gary -- http://gbenson.net/