Re: [PATCH] Move vgdb special case into remote_filesystem_is_local

[Gary Benson <gbenson@redhat.com>]

Pedro Alves wrote:
> On 04/27/2015 03:51 PM, Gary Benson wrote:
> > Valgrind GDB (vgdb) presents itself as a remote target but works
> > on the local filesystem.  gdb_bfd_open contained a special case
> > to make vgdb work with "target:" sysroots, but the implementation
> > meant that GDB would fall back to the local filesystem if *any*
> > to_fileio_open method failed with ENOSYS for *any* reason.
> 
> Can you give an example target where we'd want this to behave
> differently?
> 
> E.g,. what should happen with "target sim" ?

I don't understand what you're asking.  "target sim" doesn't use
remote_filesystem_is_local, (to_filesystem_is_local for sim is
the default, tdefault_filesystem_is_local, which returns 1 always).

> > This commit moves the vgdb special case to
> > remote_filesystem_is_local to allow the fallback to be restricted
> > only to the specific case that remote file transfer is
> > unsupported.  This commit also adds a warning which is displayed
> > the first time the fallback is used.

Thanks,
Gary

-- 
http://gbenson.net/