From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74074 invoked by alias); 6 May 2015 17:16:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74064 invoked by uid 89); 6 May 2015 17:16:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 06 May 2015 17:16:51 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t46HGn9p024837 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 6 May 2015 13:16:49 -0400 Received: from blade.nx (ovpn-116-21.ams2.redhat.com [10.36.116.21]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t46HGmrP003481; Wed, 6 May 2015 13:16:48 -0400 Received: by blade.nx (Postfix, from userid 1000) id D0FC6263C9B; Wed, 6 May 2015 18:16:47 +0100 (BST) Date: Wed, 06 May 2015 17:16:00 -0000 From: Gary Benson To: gdb-patches@sourceware.org Cc: Philippe Waroquiers Subject: Re: [PATCH] Locate executables on remote stubs without multiprocess extensions Message-ID: <20150506171647.GA12725@blade.nx> References: <20150506103145.GA30896@blade.nx> <1430932230-12551-1-git-send-email-gbenson@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430932230-12551-1-git-send-email-gbenson@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00116.txt.bz2 Gary Benson wrote: > diff --git a/gdb/gdbserver/server.c b/gdb/gdbserver/server.c > index d2e20d9..516a311 100644 > --- a/gdb/gdbserver/server.c > +++ b/gdb/gdbserver/server.c > @@ -1144,17 +1144,32 @@ handle_qxfer_exec_file (const char *const_annex, > gdb_byte *readbuf, const gdb_byte *writebuf, > ULONGEST offset, LONGEST len) > { > - char *annex, *file; > + char *file; > ULONGEST pid; > int total_len; > > if (the_target->pid_to_exec_file == NULL || writebuf != NULL) > return -2; > > - annex = alloca (strlen (const_annex) + 1); > - strcpy (annex, const_annex); > - annex = unpack_varlen_hex (annex, &pid); > - if (annex[0] != '\0' || pid == 0) > + if (const_annex[0] == '\0') > + { > + if (current_thread == NULL) > + return -1; > + > + pid = pid_of (current_thread); > + } > + else > + { > + char *annex = alloca (strlen (const_annex) + 1); > + > + strcpy (annex, const_annex); > + annex = unpack_varlen_hex (annex, &pid); > + > + if (annex[0] != '\0') > + return -1; > + } > + > + if (pid < 0) > return -1; Oops, this should be "<=". Cheers, Gary -- http://gbenson.net/