From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31943 invoked by alias); 5 May 2015 15:34:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31930 invoked by uid 89); 5 May 2015 15:34:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 05 May 2015 15:34:26 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id EA8D9340B3D; Tue, 5 May 2015 15:34:23 +0000 (UTC) Date: Tue, 05 May 2015 15:34:00 -0000 From: Mike Frysinger To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 12/18] Implement completion limiting for sim_command_completer. Message-ID: <20150505153422.GS30924@vapier> Mail-Followup-To: Keith Seitz , gdb-patches@sourceware.org References: <20150413192235.29172.13097.stgit@valrhona.uglyboxes.com> <20150413192331.29172.23243.stgit@valrhona.uglyboxes.com> <20150414152837.GA872@vapier> <5548DBC2.5010408@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="psiTe9LjpVyD9953" Content-Disposition: inline In-Reply-To: <5548DBC2.5010408@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00072.txt.bz2 --psiTe9LjpVyD9953 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1018 On 05 May 2015 08:03, Keith Seitz wrote: > On 04/14/2015 08:28 AM, Mike Frysinger wrote: > > i think you want to push this down into sim/common/sim-options.c ? > > otherwise you do all of this work only to throw away a good amount > > of it. >=20 > Eventually, yes, but not right now, if I may. I'd be more than happy > to prepare and submit a follow-up patch for sim/ in the next week or > two (pending acceptance of this patch series). >=20 > >> It does not add any tests, since the `sim' command is highly=20 > >> target-dependent and unimplemented for the majority of > >> simulators. > >=20 > > erm, the majority of simulators now have testsuites. but that > > doesn't really matter because you're updating the gdb part of the > > API, not the sim side. >=20 > Right, and I can only test it on any sim-enabled target, which I > seldom use anymore. that's pretty trivial to get though $ mkdir build $ cd build $ ../configure --target=3Dft32-elf $ make all-gdb $ ./gdb/gdb (gdb) target sim (gdb) sim -mike --psiTe9LjpVyD9953 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVSOL+AAoJEEFjO5/oN/WBJWUQANDwL0pN6jfslou5Bq0+asUK dLI/X1eBfad1eKnKpoYS1wvjeFuaQFQYOQwOHntSrOvJRc+xPCNvaa1CByLJ0pYx cwfrwFimUBSIgxPUdJlhafDNRSPJSHdWt4D4+qsea4ghjJ8Xvw1WPr3axOHZ5Mko GlU3XjQoLtdI36/qegxa1pyuCObvCi1pPTuyYPTzBNQJB8vblMLQJNekTFQofpwx n7ydwuB/6Y0h6vMD79C16aEjBjbwk0AK7id7O9px0C1HOg1fmO36T5Kddy0MeX3m 4tVXjq1E9peVnmhVqql+pKCGe392F8lUqy2TwYWGgHCDsDPR2abQeFXEwnqZ+wNZ uU72sSNu9BcRCSL7LUhhtUt9msBg04+ix1xa2ETb6lR+RZMm0+eXd8bqjJvToJs5 QfYbpBoWeGc0h9eAdxCvxHZAFAQs8Jrj1R6fjpJ74ccJLueupZPV/toaWi5F/sfO IQkoFlfaGQOcw2ff1FOlESokvgJMvxDXUnBIyElCeER/mhrJapjc+s9amNbs8bOZ z265QRKnwjU6lMmv7yQpSB02mzzwlaXu9CI/Jo0Wt9CqltOPig8sbpMJxIyJwjSF 5J3zcnAM0J9K1dD1CJJjvJBYaEGf5k02clFUv0XU3XD8s/2uVUXTZG3IpBM0Kcoo jKaVBs6oDWw4Ip0uzFcV =EF5C -----END PGP SIGNATURE----- --psiTe9LjpVyD9953--