From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29758 invoked by alias); 5 May 2015 03:01:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29747 invoked by uid 89); 5 May 2015 03:01:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 05 May 2015 03:01:28 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 02B7F340B4B; Tue, 5 May 2015 03:01:25 +0000 (UTC) Date: Tue, 05 May 2015 03:01:00 -0000 From: Mike Frysinger To: Gabriel Corona Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/2] Make gdbserver connect to SOCK_STREAM sockets Message-ID: <20150505030125.GN30924@vapier> Mail-Followup-To: Gabriel Corona , gdb-patches@sourceware.org References: <1430776463-23214-1-git-send-email-gabriel.corona@enst-bretagne.fr> <1430776463-23214-2-git-send-email-gabriel.corona@enst-bretagne.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BjavXC7V3ilNTWHC" Content-Disposition: inline In-Reply-To: <1430776463-23214-2-git-send-email-gabriel.corona@enst-bretagne.fr> X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00068.txt.bz2 --BjavXC7V3ilNTWHC Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-length: 644 On 04 May 2015 23:54, Gabriel Corona wrote: > +static int > +socket_open (char *name) const > + int sock; > + struct sockaddr_un addr; > + > + if (strlen (name) >= sizeof (addr.sun_path)) > + return -1; > + sock = socket (AF_UNIX, SOCK_STREAM, 0); prefer a blank line before the socket() > + if (sock < 0) > + return -1; > + > + addr.sun_family = AF_UNIX; > + strcpy (addr.sun_path, name); > + if (connect (sock, (const struct sockaddr *) &addr, > + sizeof (struct sockaddr_un)) < 0) > + { > + close (sock); > + return -1; > + } > + return sock; > +} blank line above this last return statement -mike --BjavXC7V3ilNTWHC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVSDKFAAoJEEFjO5/oN/WBMeEP/j0DDDvE92ylpdDKH8IhJHWE zWuvOdZhNsn+3oY6QwbRC+yFNfr7cPHpOuBehUC1Vu/9+cehL70njXOvJ22eYeDT m8CdjibSokRdbntDeaH2WtftG4cdrbiWrR8nng6kf94wcldMvaUNTU3TPgvF2y4u a4suLlAE9unYVM+rKkpG6muYw4pzbTqf3sJGLthYAWz+LYRC/9nOox6AvalZ0dYe MMzwEHJ/ojYjV7f7AOfZTyRkGbdIdKQuI81qsRPYf3eMAKoCSEC79c7DAZuKpNT3 wonwlH/ykISHNCsbbWG1kfkwxdnQfBCZ40WrML9yuQLPwmVyhvUOD702OcjEPH2J qAUQgky5tqqbw0F4CTiyhcnGQ3oBiOafKw3x9LS7+mxT0Jn6RGeIZroklrtIOzH2 E9boF/OfKJuJ+korLYn5ETkPCpGD1U4rA5tMSgRzOHNUKmaldNJmGK86zJQOefo9 s4CoY4e1J54HFHSvzq3j2W82V9g8k/F/7qEBbsdcfPlVPY0Q5/dkj+RcPJCe4YxV sqnYlT5IJyOB6qdHO7kLXYfeXu5gPYTuEVtoNZ+ED7j/sBJu6zXCfcMFR6mvb+LA TcJdqyq2s12JJYI8DigmdL6QDlZhVHnA8xCrWrWa9NfgaBf93kr1VH7c7pLc/hY/ FPthnczhslhOkR1cW321 =wOSl -----END PGP SIGNATURE----- --BjavXC7V3ilNTWHC--