From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20094 invoked by alias); 4 May 2015 07:50:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20085 invoked by uid 89); 4 May 2015 07:50:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 04 May 2015 07:50:09 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id C3F3034085F; Mon, 4 May 2015 07:50:06 +0000 (UTC) Date: Mon, 04 May 2015 07:50:00 -0000 From: Mike Frysinger To: Michael Eager Cc: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [PATCH] Support gzip compressed exec and core files in gdb Message-ID: <20150504075005.GG30924@vapier> Mail-Followup-To: Michael Eager , Eli Zaretskii , gdb-patches@sourceware.org References: <54FF77D6.7010400@eagerm.com> <5543905A.1040108@eagerm.com> <83r3r0qj5i.fsf@gnu.org> <5543F840.4040805@eagerm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XRI2XbIfl/05pQwm" Content-Disposition: inline In-Reply-To: <5543F840.4040805@eagerm.com> X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00041.txt.bz2 --XRI2XbIfl/05pQwm Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1070 On 01 May 2015 15:03, Michael Eager wrote: > On 05/01/2015 10:53 AM, Eli Zaretskii wrote: > >> Date: Fri, 01 May 2015 07:40:26 -0700 > >> From: Michael Eager > >> > >> On 03/10/2015 04:01 PM, Michael Eager wrote: > >>> Add support to automatically unzip compressed executable and core fil= es. > >>> Files will be uncompressed into temporary directory (/tmp or $TMPDIR) > >>> and are deleted when GDB exits. This should be transparent to users, > >>> except for disk space requirements. The name of the uncompressed fil= e is > >>> mentioned, but all references to the file in GDB messages is to the f= ile > >>> which the user specified. > >> > >> Attached is a revised patch. I discovered a logic error after refacto= ring > >> the code. > > > > OK for the documentation parts. > > > >> + decomp_fd =3D mkstemp (template); > > > > Do we have mkstemp on all supported platforms? >=20 > It looks like there is a version in gnulib, if not supported natively. libiberty limits itself to "mkstemps" since it provides a fallback for that= ... -mike --XRI2XbIfl/05pQwm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVRyStAAoJEEFjO5/oN/WBE+kP/igKBF9ROCwXWpmEVL/cKMU5 7c2+uvEHNieajlHz0Kkaqiq11r7f/Bq+Vj22w6/9IsFYjI+lhCXur3EKcJRqQGPm lmbSxN234LRb7ubJIdtBSs7V6qrWHg9B34QEsBXQeZBPgbXFBPHOoI0uYBfavhsP exMZG7O2mbp7i4Xy9XOEDe9sP7kHFSzXKUtEaM5Ngv0zQRpv4sGY4uXXU9FcULQw 5OYtYlyWB6rfi7GRFPqjsZT/3C9AvLiBHIztBIZ0Or7BdDlZ7l1w9HxblvyYrvgH hBZLccpswNM7a0DFFf+b7j1D6ZS3NXD8qo5aD4aTWE3iFhk0l71JToaQr228c724 ZUZ2Nflmh35yi0cuDH6YTJ7ec8s5vhBXVSwjxlLA+wbndWCb9agIoHHLzAkBElfp 4Tj5QIyGJ9nBzeh/436L/mIpC1JCISUQNYucT/JbkJnxqBQU3U5+N6SBsCQlJRf/ TyahKvXznm2tI7+VDCFTbLSYweLDySThejyMLH/zel2Cmt9K4rDVrNVihh1Jtwic Ao5JmTQE3pXCszLh2+Xiv0Y7u2qHY76Nmi/XKm8HfdhdaB0ggsO636STb2gFaSVs UZD4VzkSAwrkIvaJB31Vm+40jT+K3evMm4XXjlTrQyFyEuqVdDywO53AVbFtQr8q 4sIBqvi7/mDztQulEGXe =BfZU -----END PGP SIGNATURE----- --XRI2XbIfl/05pQwm--