From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83514 invoked by alias); 3 May 2015 14:06:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83505 invoked by uid 89); 3 May 2015 14:06:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 03 May 2015 14:06:03 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t43E61LG007682 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Sun, 3 May 2015 10:06:01 -0400 Received: from host1.jankratochvil.net (ovpn-116-27.ams2.redhat.com [10.36.116.27]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t43E5vrr003359 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 3 May 2015 10:06:00 -0400 Date: Sun, 03 May 2015 14:06:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org, Phil Muldoon Subject: Re: [PATCH v3 7/9] compile: New 'compile print' Message-ID: <20150503140557.GB18394@host1.jankratochvil.net> References: <20150411194322.29128.52477.stgit@host1.jankratochvil.net> <20150411194418.29128.3411.stgit@host1.jankratochvil.net> <5540FD9E.1020005@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5540FD9E.1020005@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00023.txt.bz2 On Wed, 29 Apr 2015 17:49:50 +0200, Pedro Alves wrote: > On 04/11/2015 08:44 PM, Jan Kratochvil wrote: > > > + case COMPILE_I_PRINT_ADDRESS_SCOPE: > > + case COMPILE_I_PRINT_VALUE_SCOPE: > > + fputs_unfiltered ("#include \n" > > OOC, why do we need the include? Added: + /* is needed for a memcpy call below. */ > > @@ -354,6 +355,114 @@ copy_sections (bfd *abfd, asection *sect, void *data) > > do_cleanups (cleanups); > > } > > > > +/* Fetch the type of COMPILE_I_EXPR_PTR_TYPE and COMPILE_I_EXPR_VAL > > + symbols in OBJFILE so we can calculate how much memory to allocate > > + for the out parameter. This avoids needing a malloc in the generated > > + code. Throw an error if anything fails. > > + Set *OUT_VALUE_TAKE_ADDRESSP depending whether inferior code should > > + copy COMPILE_I_EXPR_VAL or its address - this depends on __auto_type > > + array-to-pointer type conversion of COMPILE_I_EXPR_VAL, as detected > > + by COMPILE_I_EXPR_PTR_TYPE preserving the array type. */ > > This comment seems a bit stale. At least, I don't see an > OUT_VALUE_TAKE_ADDRESSP parameter. OK, yes, updated. Function returns NULL only for COMPILE_I_PRINT_ADDRESS_SCOPE when COMPILE_I_PRINT_VALUE_SCOPE should have been used instead. This depends on __auto_type array-to-pointer type conversion of COMPILE_I_EXPR_VAL, as detected by COMPILE_I_EXPR_PTR_TYPE preserving the array type. */ Thanks, Jan