From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55660 invoked by alias); 27 Apr 2015 06:43:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55650 invoked by uid 89); 27 Apr 2015 06:43:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 27 Apr 2015 06:43:45 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id BA5E1340D32; Mon, 27 Apr 2015 06:43:43 +0000 (UTC) Date: Mon, 27 Apr 2015 06:43:00 -0000 From: Mike Frysinger To: Nick Clifton , gdb-patches@sourceware.org Subject: Re: Commit: Obvious fixes for PR 18273 Message-ID: <20150427064343.GF4602@vapier> Mail-Followup-To: Nick Clifton , gdb-patches@sourceware.org References: <87k2x1egez.fsf@redhat.com> <20150424185326.GY12496@vapier> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FoLtEtfbNGMjfgrs" Content-Disposition: inline In-Reply-To: <20150424185326.GY12496@vapier> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00982.txt.bz2 --FoLtEtfbNGMjfgrs Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 969 On 24 Apr 2015 14:53, Mike Frysinger wrote: > On 24 Apr 2015 15:42, Nick Clifton wrote: > > --- a/sim/bfin/bfin-sim.c > > +++ b/sim/bfin/bfin-sim.c > > @@ -4318,7 +4318,7 @@ decode_dsp32alu_0 (SIM_CPU *cpu, bu16 iw0, bu16 i= w1) > > SET_AREG (1, 0); > > } > > else if ((aop =3D=3D 0 || aop =3D=3D 1 || aop =3D=3D 2) && s =3D=3D = 1 && aopcde =3D=3D 8 > > - && x =3D=3D 0 && s =3D=3D 1 && HL =3D=3D 0) > > + && x =3D=3D 0 && HL =3D=3D 0) > > { > > bs40 acc0 =3D get_extended_acc (cpu, 0); > > bs40 acc1 =3D get_extended_acc (cpu, 1); >=20 > this one i was sitting on until i could go through the ISA and figure out= the=20 > exact matching. it is duplicated as-is, but it might have been a typo an= d=20 > should have been checking a different field. but i'll follow up on that= =20 > independently. looks like deleting the check is fine. all the other fields in the encodin= g are=20 covered here or earlier. thanks! -mike --FoLtEtfbNGMjfgrs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVPdqfAAoJEEFjO5/oN/WB+QEQAKCqvqBOHGucevRt0lybo1eC KHOkj7NP2ouHDk9gSBfd4DsWYsqRK5V2I2SxB+Wt71Z/x67nhsJFXIYJnheXeEzP pzZdhisPmcd2kYGn4SJIW3Q3Rszo+1vvEZyNMGYcgzkdciTDMrTA5ohlUqRkSTdk eH0k8l9itDOKQDqdxN6L4LUxNxZyVst9jRcNdTZQvr/SFco0fV25pZxOF1gsNnR6 J1CTdmwpfgJhZjWRCfY2/F0+pQYshBMV8Itd/i5CYQzNmQ7UBn5Cv5f0ihczq+Lx 1brZ0CPLxuSL3WeYzMSJO7wt8SI9YiG1grdCq0DLLXWOlxvlMvY7W0p+ErJ99LXH eQuL+Vi8eJSEFLcfiVQr/PNtn2NVVv9MnDGAwgQvz/33DFvFtNjOnRlS984vhTTB Tcf9lE5rdnsxW1vJwi4ATkuDlseeNyI3TIYM6wkres88gnMEJ9SwAFZ2CMd70NhE w0azcfbzyNbG0xIzzXOPVSzS5pxE2KYr1nGZiZz2365qZiUcUvlGTuTNLeN1cD8N fXyd72BOKWPvkDu33xPZvxRE7flvPaMA4DldZxiic5pCb7eWrEDz8AQP5xkGEbu8 NIw5zqcMv3dnXMIqgvUDDSfnWFgCppOajbhKxjNV+7TzfO/Gr/QORoH+EYrwzOx+ JFs7kCmHg595duiuuULq =VWIK -----END PGP SIGNATURE----- --FoLtEtfbNGMjfgrs--