From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104901 invoked by alias); 23 Apr 2015 21:09:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104888 invoked by uid 89); 23 Apr 2015 21:09:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Apr 2015 21:09:23 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3NL9Kbe023147 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 23 Apr 2015 17:09:20 -0400 Received: from host1.jankratochvil.net (ovpn-116-27.ams2.redhat.com [10.36.116.27]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3NL9Gxv006176 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 23 Apr 2015 17:09:19 -0400 Date: Thu, 23 Apr 2015 21:09:00 -0000 From: Jan Kratochvil To: Eli Zaretskii Cc: gdb-patches@sourceware.org, pmuldoon@redhat.com Subject: Re: [PATCH 4/4] compile: Add 'set compile-gcc' Message-ID: <20150423210916.GA8816@host1.jankratochvil.net> References: <20150421213635.14147.15653.stgit@host1.jankratochvil.net> <20150421213657.14147.60506.stgit@host1.jankratochvil.net> <83ioco4oid.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83ioco4oid.fsf@gnu.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00916.txt.bz2 On Wed, 22 Apr 2015 09:21:14 +0200, Eli Zaretskii wrote: > > parameter of GCC's set_arguments. GCC decides on the meaning of the > > triplet_regexp parameter according to the success of: > > > > + if (access (triplet_regexp, X_OK) == 0) > > Does triplet_regexp include the .exe extension on platforms that need > it? Otherwise, 'access' will fail on those platforms. (Sorry, > couldn't see where's the actual code, so couldn't verify that myself.) Actual code is: triplet_rx = compile_gcc; add_setshow_string_cmd ("compile-gcc", class_support, &compile_gcc, so whatever user sets by 'set compile-gcc' GDB command will be passed. > > + add_setshow_string_cmd ("compile-gcc", class_support, > > + &compile_gcc, > > This doesn't offer file-name completion, does it? I think it should. Fixed. > > + By default the environment variable > > +@code{PATH} (@code{PATH} from shell that executed @value{GDBN}, not the > > +one set by @value{GDBN} command @code{set environment}). > > This sentence is incomplete, I think you need to combine it with the > next one. (I suggest to say the simple thing first, and then add the > caveat about which PATH is searched, instead of having the caveat in > the middle, making it harder to comprehend.) Changed it all a bit. > > +Besides the compiler driver @value{GDBN} needs also shared library > > +@file{libcc1.so}. It is searched in default shared library search path > > +(overridable with usual environment variable @code{LD_LIBRARY_PATH}), > > +unrelated to @code{PATH} or @code{set compile-gcc} settings. > > This is Unix logic, btw. On Windows, libcc1.dll will either be in the > same directory where the GCC driver is, or on PATH, or in libexec. So > maybe you should qualify the above by saying this is on Posix hosts; > we could then amend it when this is supported on Windows (assuming it > isn't for now). I do not think it would work on MS-Windows host as gcc/libcc1/ uses: # If any of these functions are missing, simply don't bother building # this plugin. GCC_ENABLE_PLUGINS AC_CHECK_FUNC(socketpair, , enable_plugin=no) AC_CHECK_FUNC(select, , enable_plugin=no) AC_CHECK_FUNC(fork, , enable_plugin=no) AM_CONDITIONAL(ENABLE_PLUGIN, test $enable_plugin = yes) New patch is posted at: [PATCH v3 2/2] compile: Add 'set compile-gcc' https://sourceware.org/ml/gdb-patches/2015-04/msg00915.html Message-ID: <20150423210815.GA8626@host1.jankratochvil.net> Thanks, Jan