From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25296 invoked by alias); 22 Apr 2015 14:23:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24525 invoked by uid 89); 22 Apr 2015 14:23:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 22 Apr 2015 14:23:19 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3FCC7D3A56; Wed, 22 Apr 2015 10:23:17 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id C-Ut+cidvbxQ; Wed, 22 Apr 2015 10:23:17 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 11E3D11637F; Wed, 22 Apr 2015 10:23:17 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 889A740EAD; Wed, 22 Apr 2015 07:23:17 -0700 (PDT) Date: Wed, 22 Apr 2015 14:23:00 -0000 From: Joel Brobecker To: Jon TURNEY Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fixes to Cygwin-specific signal handling Message-ID: <20150422142317.GI4764@adacore.com> References: <1429009382-21040-1-git-send-email-jon.turney@dronecode.org.uk> <20150414131615.GI4704@adacore.com> <55300C61.2080102@dronecode.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55300C61.2080102@dronecode.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-04/txt/msg00823.txt.bz2 > > current_thread = th; > > if (!current_thread) > > thread_rec (thread_id, TRUE); > > I've done this (with the last line as an assignment), but you'll > have to help me find where the Coding Standard says that. > > [1] mentions not using assignments inside if conditions, but I don't > see any mention of ?: > > [1] http://www.gnu.org/prep/standards/standards.html#Syntactic-Conventions I think I got slightly confused by that one, as to what the "?" applied to. But I guess that could be seen as a good reason for avoiding it in this case :-P. Thanks for doing it anyways, even though the reasons for it were not as strong as I thought. -- Joel