From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106954 invoked by alias); 22 Apr 2015 14:18:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106945 invoked by uid 89); 22 Apr 2015 14:18:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 22 Apr 2015 14:18:13 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4F49E11641E; Wed, 22 Apr 2015 10:18:11 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id wFguBKmP1oSq; Wed, 22 Apr 2015 10:18:11 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 217A711641D; Wed, 22 Apr 2015 10:18:11 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id A8EAF40EAD; Wed, 22 Apr 2015 07:18:11 -0700 (PDT) Date: Wed, 22 Apr 2015 14:18:00 -0000 From: Joel Brobecker To: Jon Turney Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/5] windows-nat: Don't change current_event.dwThreadId in handle_output_debug_string() Message-ID: <20150422141811.GH4764@adacore.com> References: <1429009382-21040-1-git-send-email-jon.turney@dronecode.org.uk> <1429212209-20548-1-git-send-email-jon.turney@dronecode.org.uk> <1429212209-20548-6-git-send-email-jon.turney@dronecode.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429212209-20548-6-git-send-email-jon.turney@dronecode.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-04/txt/msg00822.txt.bz2 > Since a Cygwin signal may be reported by a different thread to the thread the > signal is to be delivered to, use the signal target thread id by returning it, > rather than re-writing the thread id in current_event. > > Altering current_event.dwThreadId() will cause ContinueDebugEvent() to be > applied to the wrong thread and fail, leaving the actual thread which reported > the debug event stuck in the suspended state. > > gdb/ChangeLog: > > 2015-04-16 Jon Turney > > * windows-nat.c (handle_output_debug_string): Don't change > current_event.dwThreadId. > (get_windows_debug_event): Use thread_id, rather than relying on > current_event.dwThreadId being changed. I think this one makes better sense to me. So OK, with the same comments as for patch 4/5: I'd like the revision history to be self-sufficient, to allow anyone looking at this change years from now to be able to understand what it was that this patch was trying to do. So can you amend it so that it gives a more complete description of the problem, making it less abstract? In particular, a copy of the GDB session would show what the symptoms are, and a copy of the behavior afterwards would help. Thank you, -- Joel