Re: [PATCH 7/9 v2] Implement multiple-filesystem support for remote targets

Pedro Alves
2015-05-21T15:04:23Z

On 04/30/2015 01:05 PM, Gary Benson wrote:

> @@ -9890,6 +9935,9 @@ remote_hostio_open (struct target_ops *self,
> char *p = rs->buf;
> int left = get_remote_packet_size () - 1;
>
> + if (remote_hostio_set_filesystem (inf, remote_errno) != 0)
> + return -1;

I guess this is where the ENOSYS issue (and likewise in the native
target) we were discussing before (in the vgdb patch) comes from.
I'm not yet convinced it's a good idea to have setns==ENOSYS result
in open==ENOSYS.

Other than this issue, the whole series looks good to me.

Thanks,
Pedro Alves