From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9231 invoked by alias); 19 Apr 2015 06:44:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9027 invoked by uid 89); 19 Apr 2015 06:44:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 19 Apr 2015 06:44:16 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id CDF77340DCD; Sun, 19 Apr 2015 06:44:12 +0000 (UTC) Date: Sun, 19 Apr 2015 06:44:00 -0000 From: Mike Frysinger To: Jiri Gaisler Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v5 3/9] sim/erc32: Access memory subsystem through struct memsys. Message-ID: <20150419064411.GC17952@vapier> Mail-Followup-To: Jiri Gaisler , gdb-patches@sourceware.org References: <1428093356-7296-1-git-send-email-jiri@gaisler.se> <1428093356-7296-4-git-send-email-jiri@gaisler.se> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="O3RTKUHj+75w1tg5" Content-Disposition: inline In-Reply-To: <1428093356-7296-4-git-send-email-jiri@gaisler.se> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00719.txt.bz2 --O3RTKUHj+75w1tg5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 980 On 03 Apr 2015 22:35, Jiri Gaisler wrote: > * exec.c (dispatch_instruction) : Access memory through common API. no space before the : > * interf.c (run_sim, sim_close, sim_write, sim_read, flush_windows) : As= above. same here > * sis.h : Define struct memsys as common memory API. Remove declaration = of and here > --- a/sim/erc32/interf.c > +++ b/sim/erc32/interf.c > @@ -37,16 +37,13 @@ > #define PSR_CWP 0x7 >=20=20 > extern struct disassemble_info dinfo; > -extern struct pstate sregs; > extern struct estate ebase; >=20=20 > -extern int ctrl_c; > extern int nfp; > extern int ift; > extern int rom8; > extern int wrp; > extern int uben; > -extern int sis_verbose; the changelog needs to mention deletion of global vars/prototypes/etc... sorry, i don't point these things out to be difficult ... it's just that th= ey=20 would need to be fixed before merging, and i really really don't want to do= it=20 myself. -mike --O3RTKUHj+75w1tg5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVM067AAoJEEFjO5/oN/WBzqoQAN7sp+7tVg1AE5ewwPohjHbk 2PqGQnSEebyVF5YKW3EXR9EbJ5qX0h+WaR0W9M42rzjL8xuXTftVxSrU6O4L+Egu DzPYkpp9SnGlEJ88VUlYcQyxBAAqqQgk+vz4RSqnlMi3683Y//LAR7Hq5++MGCg1 8m2bhMjD0/ykHy8vRCug95z7gxEqypCOSdjpMUvlB5zhpQizezthN18rbsNdlWN2 p58niLxWG8DuSCGiwvBuU0g5Hg+4WLjmxl0r+ZzP5rPefstGV5KBr3mPeWNPB9OD 4EGVjy8gpOzCO73UB0HbYLMskr4QZpLRRXByzCadgm6kWgNPhVe69syHHCZUYSQG 9C+1a2Wo0cvc6V+Qs/l/z+ZPjtlgy4neyKXQOtr3Ibns5XH98x99sO/Mb4L59hSP GiX7mvNrfJpGsnxkaRSLkhwKODw44OofEXeETwsmISodVdmusx1d1kwqVR+dI8ra htFxMLOAexE9tMinfFX8RqhauzadZDDTUA54OKLmqJle92j4d1vn8KWxBnFZ16Q1 dU/wX4RI9+Wzezf6K1B+wo5WLaenH6UzOcKHBKznuN/dm6Um/rUHkX1IjQmyI1/b WekEIYMKHqmOmDuTUwVc7xrHgcjBOQy7HVOpxwWS4j/nEV6DQrl/sF/CLEhofXcE sjQq+m1PIMJyJ0Moj8rg =69Mc -----END PGP SIGNATURE----- --O3RTKUHj+75w1tg5--