From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11477 invoked by alias); 17 Apr 2015 13:44:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11462 invoked by uid 89); 17 Apr 2015 13:44:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 17 Apr 2015 13:44:43 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3HDiW7H010766 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 Apr 2015 09:44:33 -0400 Received: from blade.nx (ovpn-116-95.ams2.redhat.com [10.36.116.95]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3HDiVrG016507; Fri, 17 Apr 2015 09:44:32 -0400 Received: by blade.nx (Postfix, from userid 1000) id D9005263FBA; Fri, 17 Apr 2015 14:44:30 +0100 (BST) Date: Fri, 17 Apr 2015 13:44:00 -0000 From: Gary Benson To: Doug Evans Cc: gdb-patches Subject: Re: [PATCH 4/7] Remove linux_proc_pid_get_ns Message-ID: <20150417134430.GC26681@blade.nx> References: <1429186791-6867-1-git-send-email-gbenson@redhat.com> <1429186791-6867-5-git-send-email-gbenson@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00677.txt.bz2 Doug Evans wrote: > On Thu, Apr 16, 2015 at 5:19 AM, Gary Benson wrote: > > This commit removes linux_proc_pid_get_ns, and updates its only > > use to use linux_ns_same instead. > > > > gdb/ChangeLog: > > > > * linux-thread-db.c (nat/linux-namespaces.h): New include. > > (check_pid_namespace_match): Use linux_ns_same rather than > > linux_proc_pid_get_ns to spot PID namespace mismatches. > > * nat/linux-procfs.h (linux_proc_pid_get_ns): Remove. > > * nat/linux-procfs.c (linux_proc_pid_get_ns): Likewise. > > LGTM. > one nit below [snip] > I see we're using pid_t here. > I think we talked before about a type for pids. > Since this is all linux specific code maybe use pid_t more in this > patch set? I could do that. It would likely only be in linux-namespaces.[ch] and maybe one or two places in linux-nat.c, all the other stuff is in the target vectors. Cheers, Gary -- http://gbenson.net/