From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2360 invoked by alias); 12 Apr 2015 08:21:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2347 invoked by uid 89); 12 Apr 2015 08:21:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 12 Apr 2015 08:21:48 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 81F573409D1; Sun, 12 Apr 2015 08:21:46 +0000 (UTC) Date: Sun, 12 Apr 2015 08:21:00 -0000 From: Mike Frysinger To: Hans-Peter Nilsson Cc: gdb-patches@sourceware.org Subject: Re: Patch, sim: fix m68hc11 and iq2000 testsuites using dejagnu baseboard files Message-ID: <20150412082145.GG16816@vapier> Mail-Followup-To: Hans-Peter Nilsson , gdb-patches@sourceware.org References: <20150407025822.GR16816@vapier> <201504070359.t373xCno025790@ignucius.se.axis.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PBu/a+gn9/ndsyD5" Content-Disposition: inline In-Reply-To: <201504070359.t373xCno025790@ignucius.se.axis.com> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00435.txt.bz2 --PBu/a+gn9/ndsyD5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2240 On 07 Apr 2015 05:59, Hans-Peter Nilsson wrote: > > From: Mike Frysinger > > Date: Tue, 7 Apr 2015 04:58:22 +0200 >=20 > > odd, it's working for me. what is different about your environment ? = i'm just=20 > > doing `make sim-check`. >=20 > This is old. :) You never specify the dejagnu sim baseboards > (defaulting to "unix.exp" the native one), while I do; see > the subject. I.e. you never pass > RUNTESTFLAGS=3D--target_board=3Diq2000-sim etc. Let's no argue > about the validity of doing either: the simulator is at such a > low level that its test-suite can be argued to know how to build > simple programs for itself, but it should also not have to have > a different baseboard required than the rest of a unified-tree > (aka. uberbaum) setup. (Not that iq2000-elf nor m68hc11 appear > to have actively maintained toolchains...) i'm not trying to say you're flow is wrong. i'm merely asking how it diffe= rs=20 from my own. > > i really don't want the sim to get into the business of fighting dejagn= u over=20 > > what a sane environment looks like. >=20 > Too late. >=20 > > but i also don't want to start sprinkling=20 > > this logic over all targets. so moving the existing mips logic to run_= sim_test=20 > > in lib/sim-defs.exp seems like the least worse option to me. >=20 > And that's what I referred to as the "too smart" alternative of > moving it do run_sim_test (I did have a quick look). Better > keep it target-specific, as it's the specific target board file > that's "broken" (besides the "-Wl,"-stripping). If those > targets change in level of activity, I expect the ldscript > business to be fixed too. the sim is not board specific, nor does the testsuite (generally) care abou= t the=20 C library. it certainly is not a test ground for making sure newlib/libglo= ss=20 itself is bug free (that's what testsuites in those projects are for). tha= t=20 leads me to the opinion that board-specific linkage information does not ma= ke=20 sense in the sim so we should simply clear it for all targets. in fact, we= want=20 the sim to be board agnostic (ignoring the model support, and tests that=20 exercise those models directly, but is still orthogonal to dejagnu setup). -mike --PBu/a+gn9/ndsyD5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVKisZAAoJEEFjO5/oN/WBlacQAKaSCIkuxsLEbCu7D+I27HON 4JhKAIiJkMAjMpmaG7CLf9yxH5FwXK8SnLPHBQqOBgyIqBjmjl+IzJ9KvHx9i7P2 2vB/el3VmyxeVYGpM9W7awmuNFtgk9EKSrfik3qrU7npXc4NuAgJLT8GtTEqMiWv ZA1LV058zz/LI0lgeq34ndUhDdva2E0UvnIu6v2drcmXtr6mepOR9/P2A4UPCrjP bl9+ZRo3CGYo0DbKGc9jgE/aSh/gx2lhdxykbLmsVpZODlGS1ZrmRcztkQbXgm0+ 1xxtl2bgINXAEJiLV4jBOTfwtkCzcXhceBPOzX9hbgPxNYanJsvgHF8U6l6aiP3I 3Njw/nVxAN6Y6v6qGPbf0U54WSKmxUJ4nfX9w348zDxLVVJ/9AgkDcOk8klUyMfP kN8D9vF3fxne8/L+veo529O6HGSXqK87ux+Ju24HasU4dUcbX0y1I8ARPTlE7Gpw knWxqpKwpFPW1xr0TSbfb0zWbXVrQtbJAsYCfRvUz4zNmcK7/Pk8rCsqGGAtUXd+ jIjPuoKQTySIu9k7fAhJ8flRFnw1wnB0ojS6tdvVrP4ej+fJTTjywJxWFJmkz2Z7 q99t4pwL+cryWGJdSKNQW8BPlX2d3X90LHf1hqg9B+7+VRGZGftqJIKBFKPOT7q5 /20PPdJgcBX7/xLWnby5 =/ukG -----END PGP SIGNATURE----- --PBu/a+gn9/ndsyD5--