From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10900 invoked by alias); 9 Apr 2015 13:21:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10887 invoked by uid 89); 9 Apr 2015 13:21:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 09 Apr 2015 13:21:35 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id B104D8F2FA for ; Thu, 9 Apr 2015 13:21:34 +0000 (UTC) Received: from blade.nx (ovpn-116-118.ams2.redhat.com [10.36.116.118]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t39DLXlR008218; Thu, 9 Apr 2015 09:21:34 -0400 Received: by blade.nx (Postfix, from userid 1000) id 1ECEF26410C; Thu, 9 Apr 2015 14:21:33 +0100 (BST) Date: Thu, 09 Apr 2015 13:21:00 -0000 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Introduce new shared function remote_fileio_to_fio_error Message-ID: <20150409132132.GA30389@blade.nx> References: <1428573072-8639-1-git-send-email-gbenson@redhat.com> <552651D0.9090302@redhat.com> <20150409105026.GA16881@blade.nx> <55265BCC.2080209@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55265BCC.2080209@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00332.txt.bz2 Pedro Alves wrote: > On 04/09/2015 11:50 AM, Gary Benson wrote: > > Pedro Alves wrote: > > > On 04/09/2015 10:51 AM, Gary Benson wrote: > > > > This commit introduces a new shared function to replace three > > > > identical functions in various places in the codebase. > > > > > > > > Ok to commit? > > > > > > This is OK, but I think the "remote" in the name is really wrong. > > > This is converting a _host_ errno to a fileio error. I think the > > > function name should reflect that, and not mention remote at all. > > > > Yeah, I kind of thought this when I was writing the patch, but I > > was also thinking about other things :) > > > > I'm happy to make another patch to rename common-remote-fileio.* > > to common-fileio.* and rename the functions accordingly. > > I'd prefer even dropping the "common" from the file name. > host-fileio.* for example would indicate what the file actually does. Or just fileio.*. > > Should I push this one first and then make a second, or would you > > like the rename first and an updated version of this patch second? > > I'd prefer the former (less work for me!) but I can do the latter > > if you want it that way. > > Yeah, push what you have first. I pushed it. Will mail the renaming patch soon. Cheers, Gary -- http://gbenson.net/