From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5486 invoked by alias); 8 Apr 2015 03:09:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5432 invoked by uid 89); 8 Apr 2015 03:09:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 08 Apr 2015 03:09:46 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id B92CC340691; Wed, 8 Apr 2015 03:09:43 +0000 (UTC) Date: Wed, 08 Apr 2015 03:09:00 -0000 From: Mike Frysinger To: Yoshinori Sato Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][SIM] Add RXv2 simulation Message-ID: <20150408030943.GS16816@vapier> Mail-Followup-To: Yoshinori Sato , gdb-patches@sourceware.org References: <87384c7a0v.wl-ysato@users.sourceforge.jp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ScUgq5oMe+fJq4F1" Content-Disposition: inline In-Reply-To: <87384c7a0v.wl-ysato@users.sourceforge.jp> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00248.txt.bz2 --ScUgq5oMe+fJq4F1 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1061 On 07 Apr 2015 15:00, Yoshinori Sato wrote: > This patches added new instructions simulation for RX archtecture. please add some tests. if you look in sim/testsuite/sim/, you should be ab= le to=20 copy over something simple like mcore and then write a few basic .s files t= o=20 test the new insns. just style comments otherwise -- i'm not familiar with the RX ISA > + tprintf("sqrt(%g) =3D %g\n", da, sqrt(da)); all calls need a space before the ( tprintf ("sqrt(%g) =3D %g\n", da, sqrt (da)); this comes up a few times in your patch > + /* Less than 0.49999 */ GNU style comments have a period at the end followed by two spaces: /* Less than 0.49999. */ this comes up a few times in your patch > + whole_bits ++; no space before the ++ operator this comes up a few times in your patch > + while (! (whole_bits & 0x80000000UL)) no space after the ! > + if (tag) { printf (tag); tag =3D 0; } i guess not really a new problem, but you're changing this code so you migh= t as=20 well fix it, but this should not be one line -mike --ScUgq5oMe+fJq4F1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVJJv3AAoJEEFjO5/oN/WB0WAP/2Yg+uTYmd/DrWhrBNuykyOO oeomlin6lJPS/qCLE/QcYHM4mtUOH0z7kWnGgWmQB2ASLjbViZ0QNWeDTstrRxGv lxl0ulcQCmRXwNwgZ9J6az9gaqODpULhv97wgyOr9/t1LkZhb8DtKtj2wWfcnF87 c6S4QQFIHPjYp+UoB3NrkbXd3OcqIRf0R9c/FI3w4CRlOXQWrL6bc18obyWeJltQ hYXJKwoyJU2Nv9vBCEH806PYNwPRv+lQaWwWXYXALRvsUUBUcFgT4hkEfLFouExX ylPltdEtPl7sQYvyO1kkMN0mIKRJddVkE7JUd6gm68jxVvAbz+eJO45ySZcLve70 OC5S4Nbz+v4nOJMqKsUDdnbE+YrLwKACl6k2BUbnGy0UrQkPRPEW7BSS3UExBR9p WjJXwoXz5Ia4VgmGgTSRf42Aj1z3i6OGpPYKBJ/6LFtJivg+plochcnqlnlvldnv wor0QTye3PrYLIB4ekK3Ne31cE0EoCwvnPLvTlRgm/kYRey3ZBYje9cFDIv6q5y8 VvQEyJ7oDCrT9et+c0+nB4X0iKb5LlIXloZR0D9K+erc3PWwlvHrQH9ZvOort38H FLbHhoTz6XLLWXDVllRtloBE3GVCSRXwpsswyT7u85zK2WYmFf4xCXI0Nfy/+6S5 g7G11t2ZjHSCmrd0fF6H =7lbQ -----END PGP SIGNATURE----- --ScUgq5oMe+fJq4F1--