From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: palves@redhat.com (Pedro Alves)
Cc: peterschauer@gmx.net (Peter Schauer), qiyaoltc@gmail.com (Yao Qi),
gdb-patches@sourceware.org
Subject: Re: [rfc, spu] Don't call set_gdbarch_cannot_step_breakpoint in spu_gdbarch_init
Date: Tue, 07 Apr 2015 12:45:00 -0000 [thread overview]
Message-ID: <201504071245.t37CjfGk007933@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <551D04AC.7000206@redhat.com> from "Pedro Alves" at Apr 02, 2015 09:58:20 AM
Pedro Alves wrote:
> Ulrich, any idea why cannot_step_breakpoint was ever needed
> for the SPU?
It's been set since spu-tdep.c was committed upstream, and in
fact it's set in every single version in our internal repositories
of the code before it went upstream, too. (Going back over 10 years.)
But I don't know why it was added either, since SPU has been using
software single-step forever too, and even the very first version of
GDB we patched to support SPU would ignore cannot_step_breakpoint
for software single-step architectures ...
So I'd say just go ahead and remove it.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2015-04-07 12:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 14:52 Yao Qi
2015-03-20 17:48 ` Pedro Alves
2015-04-01 20:35 ` Peter Schauer
2015-04-02 8:58 ` Pedro Alves
2015-04-02 9:09 ` Peter Schauer
2015-04-02 9:38 ` Pedro Alves
2015-04-02 12:44 ` Yao Qi
2015-04-07 12:45 ` Ulrich Weigand [this message]
2015-04-08 15:06 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201504071245.t37CjfGk007933@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=peterschauer@gmx.net \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox