From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48141 invoked by alias); 7 Apr 2015 09:08:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48132 invoked by uid 89); 7 Apr 2015 09:08:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 07 Apr 2015 09:08:48 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3798g92011931 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 7 Apr 2015 05:08:42 -0400 Received: from blade.nx (ovpn-116-118.ams2.redhat.com [10.36.116.118]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3798fBW000711; Tue, 7 Apr 2015 05:08:42 -0400 Received: by blade.nx (Postfix, from userid 1000) id 117F526410B; Tue, 7 Apr 2015 10:08:41 +0100 (BST) Date: Tue, 07 Apr 2015 09:08:00 -0000 From: Gary Benson To: Eli Zaretskii Cc: Doug Evans , gdb-patches@sourceware.org Subject: Re: [PATCH 5/7] Implement remote_pid_to_exec_file using qXfer:exec-file:read Message-ID: <20150407090840.GB22271@blade.nx> References: <1427887341-31819-1-git-send-email-gbenson@redhat.com> <1427887341-31819-6-git-send-email-gbenson@redhat.com> <834mozsxtq.fsf@gnu.org> <83fv8djhp0.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83fv8djhp0.fsf@gnu.org> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00188.txt.bz2 Eli Zaretskii wrote: > > From: Doug Evans > > Cc: Gary Benson , gdb-patches@sourceware.org > > Date: Mon, 06 Apr 2015 10:00:08 -0700 > > > > Eli Zaretskii writes: > > > > > > Date: Wed, 1 Apr 2015 12:22:19 +0100 > > > > > > > > +qXfer:exec-file:read > > > > + Return the pathname of the file that was executed to create a > > > ^^^^^^^^^^^^^^^^^^^^^^^^ > > > "the name of the file" > > > > > > OK with this change. > > > > > > > +@item qXfer:exec-file:read:@var{annex}:@var{offset},@var{length} > > > > +@anchor{qXfer executable filename read} > > > > +Return the pathname of the file that was executed to create a process > > > ^^^^^^^^^^^^^^^^^^^^^^^^ > > > Likewise. > > > > > > Otherwise, the documentation parts are OK. > > > > "the name of the file" is ambiguous though. > > Is it the full path name of the file? Or the base name? > > I don't know the answers, but if this is a "full path name", then > "the full absolute name of the file" will convey that. It should be absolute. I will use "the full absolute name of the file" as Eli suggests. Thanks, Gary -- http://gbenson.net/