From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87100 invoked by alias); 2 Apr 2015 13:00:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86309 invoked by uid 89); 2 Apr 2015 13:00:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 02 Apr 2015 13:00:38 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t32D0aIw024542 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 2 Apr 2015 09:00:37 -0400 Received: from blade.nx (ovpn-116-118.ams2.redhat.com [10.36.116.118]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t32D0YbV005268; Thu, 2 Apr 2015 09:00:35 -0400 Received: by blade.nx (Postfix, from userid 1000) id 994D226410B; Thu, 2 Apr 2015 14:00:33 +0100 (BST) Date: Thu, 02 Apr 2015 13:00:00 -0000 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/9] New default sysroot "target:" Message-ID: <20150402130033.GA31277@blade.nx> References: <1426870087-32654-1-git-send-email-gbenson@redhat.com> <551BE1F1.4020008@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <551BE1F1.4020008@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00105.txt.bz2 Pedro Alves wrote: > On 03/20/2015 04:47 PM, Gary Benson wrote: > > This series introduces a new "target:" prefix to "set sysroot". > > Files specified with a "target:" prefix will be loaded via the > > target: from the remote if the target is remote, and from the > > local file system otherwise. This new prefix replaces the > > "remote:" prefix, and the final patch in the series makes it > > the default. > > > > The way the "target:" prefix is implemented differs somewhat > > from the way the "remote:" prefix was implemented: > > > > - It's hooked in at a lower level. The remote stuff looked to > > have been added piecemeal: various BFD-opening functions did > > checks on their filenames and diverted to remote_bfd_open. > > There was also gdb_bfd_open_maybe_remote, which handled both > > local and remote cases. The "target:" prefix is baked into > > gdb_bfd_open, so all functions that open BFDs gain support. > > > > - Various functions locally strip the "target:" prefix from the > > filenames they're working on if the target filesystem is the > > same as the local filesystem. This serves two purposes: > > > > 1) It ensures files accessed locally are handled the same > > way regardless of how they are specified. Things like > > the shared library search algorithm in solib_find, for > > example. > > > > 2) It avoids cluttering GDB's output with "target:" > > prefixes. > > > > Built and regtested on RHEL 6.6 x86_64. > > > > Ok to commit? > > Awesome work. > > Please remember to update the LocalRemoteFeatureParity page > once this is in. This is now pushed, thanks for the review. I deleted the bit about remote:->target: on the LocalRemoteFeatureParity page, I hope that's correct. I also made a comment on one of the bugs (neither is ready to be closed yet). Cheers, Gary -- http://gbenson.net/