From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19275 invoked by alias); 1 Apr 2015 17:17:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19188 invoked by uid 89); 1 Apr 2015 17:17:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 01 Apr 2015 17:17:24 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 67C0F3407DE; Wed, 1 Apr 2015 17:17:18 +0000 (UTC) Date: Wed, 01 Apr 2015 17:17:00 -0000 From: Mike Frysinger To: Bernhard Reutner-Fischer Cc: "H.J. Lu" , Binutils , GDB , GCC Patches Subject: Re: PATCH: Update --with-system-zlib Message-ID: <20150401171721.GO25224@vapier> Mail-Followup-To: Bernhard Reutner-Fischer , "H.J. Lu" , Binutils , GDB , GCC Patches References: <20150401165431.GL25224@vapier> <4FC39AF9-5742-4F8C-80F0-93E382080969@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ffBYM5qgR8HH9Mta" Content-Disposition: inline In-Reply-To: <4FC39AF9-5742-4F8C-80F0-93E382080969@gmail.com> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00068.txt.bz2 --ffBYM5qgR8HH9Mta Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1030 On 01 Apr 2015 19:05, Bernhard Reutner-Fischer wrote: > On April 1, 2015 6:54:31 PM GMT+02:00, Mike Frysinger wrote: > >On 01 Apr 2015 05:04, H.J. Lu wrote: > >> --- a/config/zlib.m4 > >> +++ b/config/zlib.m4 > >> @@ -9,8 +9,10 @@ AC_DEFUN([AM_ZLIB], > >> zlibinc=3D"-I\$(srcdir)/../zlib" > >> AC_ARG_WITH(system-zlib, > >> [AS_HELP_STRING([--with-system-zlib], [use installed libz])], > >> - zlibdir=3D > >> - zlibinc=3D > >> + if test x$with_system_zlib =3D xyes ; then > >> + zlibdir=3D > >> + zlibinc=3D > >> + fi > >> ) > > > >this is inside the 3rd arg, so normally you check $withval. this code > >will=20 > >still work as the generated shell does: > >if test "${with_system_zlib+set}" =3D set; then : >=20 > Why doesn't this expand to test -n "${with_system_zlib+set}" > nowadays, BTW? Would be faster to parse and supposedly sums up quite a bi= t, fwiw. question for the autoconf list ? although note that this is autoconf-2.64 as that is what the tree has locke= d=20 itself to currently. -mike --ffBYM5qgR8HH9Mta Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVHCghAAoJEEFjO5/oN/WB8nYQAKyTf7Pssy2xOBwNwRhKzdP9 YpHAUKWOO0f+xzfRR1qQLpHv5y9eqBfOzYgk2GetwN31vgOlKg7ajKNk/S4zbhPk GExKp76yK81HRTCSEhWTv1098ZvUMYiXlHxyGr2LYUNbrxSL+JN4EX7O+yQTqdJ8 6IN93slf/Q/5Oy5XeUrO2mM3kyqKFkDsS+yE2SXYJfKgnPjDSKwB5lK8i8fqOrHr YKquwbpi3fWqcc7/a5hwVd/AyYfyuVc93HbHHkNFFhU/D1JX3B1P6lUL6/T2uQ+v eI3HWB8Z5rAA62EDxgRfzebWq9Hmzor2afaqBztrymukOpBWWGxrEAcOnLfHUoOd 90zojotEm9RLXLaV3CJxOL2vGvfklyXLaSn2cNP0cgZ6HKoxTdQymfWRKrK0WtNH Wyb0xoXGnQbryr803Nu1mtFyJfBswyflP2WdXR+VaLtUGC9N/r1sX8zkmNFx86i6 eNkoQx1dl1Ujcco6D8qDOHEgi8nIXjBFIXVK0EeNn4MlHWF/ZhHHZSY57IgVLEEB c20AagMNKZNI0AbOfFDbNtL4dfZ7HrKzlnzDSJnaoHhlb2KuVaplbHIOUhC/IxWV Ad/iu11z3x5nDh34mWrjvm4nCrtJKq2rMeg5k3KZwj42JjCIDdflSHbluyNK+P9L ovHaeVnQ4cIqp+v15XKz =ZY53 -----END PGP SIGNATURE----- --ffBYM5qgR8HH9Mta--