From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83334 invoked by alias); 1 Apr 2015 14:12:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83321 invoked by uid 89); 1 Apr 2015 14:12:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 01 Apr 2015 14:12:48 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id AB6818EA23 for ; Wed, 1 Apr 2015 14:12:47 +0000 (UTC) Received: from blade.nx (ovpn-116-118.ams2.redhat.com [10.36.116.118]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t31ECkx5025506; Wed, 1 Apr 2015 10:12:47 -0400 Received: by blade.nx (Postfix, from userid 1000) id 4E01E26410B; Wed, 1 Apr 2015 15:12:46 +0100 (BST) Date: Wed, 01 Apr 2015 14:12:00 -0000 From: Gary Benson To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 8/9] Make the default sysroot be "target:" Message-ID: <20150401141246.GF655@blade.nx> References: <1426870087-32654-1-git-send-email-gbenson@redhat.com> <1426870087-32654-9-git-send-email-gbenson@redhat.com> <551BE151.4070900@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <551BE151.4070900@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00048.txt.bz2 Pedro Alves wrote: > On 03/20/2015 04:48 PM, Gary Benson wrote: > > This commit makes GDB default to a sysroot of "target:". > > One testcase needed updating as a result of this change. > > That's because when the sysroot is "target:" and the filesystem is > remote, the sysroot is stripped from the "Inferior loaded" message, > right? A short comment in the test would help. > > OK with that change. I reorganized this a little while adding the comment. I'll commit this: diff --git a/gdb/testsuite/gdb.base/break-probes.exp... index 1591c33..23aca8f 100644 --- a/gdb/testsuite/gdb.base/break-probes.exp +++ b/gdb/testsuite/gdb.base/break-probes.exp @@ -66,6 +66,10 @@ if { $using_probes } { } } + # GDB strips "target:" from the start of filenames when + # operating on the local filesystem + regsub "^target:" "$sysroot" "(target:)?" sysroot + # Run til it loads our library set test "run til our library loads" set not_loaded_library 1 Cheers, Gary -- http://gbenson.net/